Making name of script globals type hidden #43425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tTypeSymbol() accessible
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Portable/SymbolDisplay/SymbolDisplayVisitor.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Apr 23, 2020
src/Compilers/CSharp/Test/Symbol/SymbolDisplay/SymbolDisplayTests.cs
Outdated
Show resolved
Hide resolved
mizuniga
changed the title
tmat
changed the title
AlekseyTs
reviewed
May 13, 2020
AlekseyTs
reviewed
May 13, 2020
src/Compilers/VisualBasic/Portable/Compilation/VisualBasicCompilation.vb
Outdated
Show resolved
Hide resolved
|
Done with review pass (iteration 10) #Closed |
|
@dotnet/roslyn-compiler Can we have a second review please? |
jaredpar
approved these changes
Jun 17, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes global types symbol from compilation and changed symbol display so that the name of global type is now shown when hovering over a method, field, property, etc.
Fixes #5983