Remove public API on DocumentOptionSet #43428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#42931 added this API as we thought converting the base `OptionSet` type's abstract method to non-abstract and removing the override on `DocumentOptionSet` would be a binary breaking change for callers. However, based on the public API review meeting, it was identified that it would indeed not be a breaking change as the compiler would have emitted a callvirt to `OptionSet.GetOption`.
mavasani
requested review from
jasonmalinowski,
sharwell,
333fred and
AlekseyTs
333fred
approved these changes
Apr 17, 2020
JoeRobich
approved these changes
Apr 17, 2020
jasonmalinowski
approved these changes
Apr 17, 2020
|
Thanks @jinujoseph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42931 added this API as we thought converting the base type's
OptionSet.GetOptionmethod from an abstract to non-abstract method and removing the override onDocumentOptionSetwould be a binary breaking change for callers. However, based on the public API review meeting, it was identified that it would indeed not be a breaking change as the compiler would have emitted a callvirt toOptionSet.GetOption.