Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Simplify import of Microsoft.VsSDK.targets #43444

Merged
merged 1 commit into from
Apr 17, 2020
Merged

🧹 Simplify import of Microsoft.VsSDK.targets #43444

merged 1 commit into from
Apr 17, 2020

Conversation

sharwell
Copy link
Member

No description provided.

@sharwell sharwell requested a review from a team as a code owner April 17, 2020 15:05
@sharwell sharwell mentioned this pull request Apr 17, 2020
Merged
@sharwell sharwell changed the title Simplify import of Microsoft.VsSDK.targets 🧹 Simplify import of Microsoft.VsSDK.targets Apr 17, 2020
@tmat
Copy link
Member

tmat commented Apr 17, 2020

Have you checked this is not a problem? https://dev.azure.com/devdiv/DevDiv/_workitems/edit/365685?fullScreen=false

@sharwell
Copy link
Member Author

@tmat Yes, I verified with build logging in Visual Studio that design time builds for this project do not fail.

@sharwell sharwell merged commit a045e96 into dotnet:master Apr 17, 2020
@ghost ghost added this to the Next milestone Apr 17, 2020
@sharwell sharwell deleted the unnecessary-conditions branch April 17, 2020 21:11
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.7.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @tmat @jasonmalinowski