Use new record equality specification #43626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
changed the title
Per design changes, record equality is now defined using all instance fields, instead of just record fields.
333fred
reviewed
Apr 28, 2020
src/Compilers/CSharp/Test/Symbol/Symbols/AnonymousTypesSymbolTests.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Apr 28, 2020
src/Compilers/CSharp/Test/Symbol/Symbols/AnonymousTypesSymbolTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Apr 28, 2020
|
ping @gafter for review |
gafter
reviewed
Apr 30, 2020
src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEquals.cs
Outdated
Show resolved
Hide resolved
gafter
reviewed
Apr 30, 2020
src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEquals.cs
Outdated
Show resolved
Hide resolved
gafter
reviewed
Apr 30, 2020
| : F.LogicalAnd(retExpression, nextEquals); | ||
| } | ||
|
|
||
| RoslynDebug.AssertNotNull(retExpression); |
There was a problem hiding this comment.
AssertNotNull [](start = 24, length = 13)
This assertion does not appear justified.
There was a problem hiding this comment.
Earlier fields is asserted to have more than 1 element, there will always be at least one iteration of the foreach.
There was a problem hiding this comment.
How is there always at least one iteration of the foreach? According to the spec a record can have an empty parameter list.
In reply to: 418268985 [](ancestors = 418268985)
|
Finished a quick scan of Iteration 2. |
gafter
reviewed
May 1, 2020
| TList fields, | ||
| SyntheticBoundNodeFactory F) where TList : IReadOnlyList<FieldSymbol> | ||
| { | ||
| Debug.Assert(fields.Count > 0); |
There was a problem hiding this comment.
fields.Count > 0 [](start = 25, length = 16)
How is this justified? Please add a PROTOYPE, issue, or bullet in the test plan.
gafter
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per design changes, record equality is now defined using all instance
fields, instead of just record fields.
Spec changes at dotnet/csharplang#3396