-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend init
keyword
#43865
Recommend init
keyword
#43865
Conversation
Tagging @CyrusNajmabadi for small review. Trying to get this in before Monday so it's in the bits Mads demos. |
{ | ||
return | ||
context.TargetToken.IsAccessorDeclarationContext<PropertyDeclarationSyntax>(position, SyntaxKind.InitKeyword) || | ||
context.TargetToken.IsAccessorDeclarationContext<IndexerDeclarationSyntax>(position, SyntaxKind.InitKeyword); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need:
class C
{
init
{
}
}
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we brainstormed that, but that wasn't decided yet.
@@ -138,6 +138,7 @@ private static ImmutableArray<IKeywordRecommender<CSharpSyntaxContext>> GetKeywo | |||
new SealedKeywordRecommender(), | |||
new SelectKeywordRecommender(), | |||
new SetKeywordRecommender(), | |||
new InitKeywordRecommender(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort.
No description provided.