-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module initializers deterministic ordering #43964
Merged
RikkiGibson
merged 9 commits into
dotnet:features/module-initializers
from
RikkiGibson:mi-multiple
May 7, 2020
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4c804d2
Support multiple in deterministic order
RikkiGibson d78f276
Don't crash in ConcurrentSet.CopyTo
RikkiGibson 0d9bdd9
Merge remote-tracking branch 'upstream/features/module-initializers' …
RikkiGibson 488e63d
Fix test
RikkiGibson 2c82cf8
Add various tests
RikkiGibson 3892e4b
Implement CopyTo. Update tests.
RikkiGibson 0078cf2
Address feedback from previous PR
RikkiGibson 6d8582a
Address feedback
RikkiGibson 4dd65de
Address feedback
RikkiGibson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for
LexicalOrderSymbolComparer
indicates it's only supported forSymbol
instances that are declared in the same container:Module initializers can be declared across containers though. Have you verified that
LexicalOrderSymbolComparer
is supported for this scenario? If so can you clean up the documentation to reflect the correctly supported behaviors?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, reading the source indicates this and
ModuleInitializersTests.MultipleInitializers_MultipleFiles
seems to demonstrate this. I will fix up the documentation.