Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in global:: qualified constant in a switch case. #43965

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix regression in global:: qualified constant in a switch case. #43965

merged 1 commit into from
May 6, 2020

Conversation

gafter
Copy link
Member

@gafter gafter commented May 4, 2020

Fixes #43960

@gafter gafter requested a review from a team as a code owner May 4, 2020 21:48
@gafter gafter self-assigned this May 4, 2020
@gafter gafter added this to the 16.7.P1 milestone May 4, 2020
@gafter
Copy link
Member Author

gafter commented May 4, 2020

@dotnet/roslyn-compiler May I please have a couple of reviews for this tiny but urgent bug fix for a regression in 16.7-preview1?

@jaredpar What approval(s) do I need aside from code reviews?

ghost
ghost approved these changes May 5, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@333fred 333fred removed the auto-merge label May 5, 2020
@JoeRobich JoeRobich merged commit 34bff41 into dotnet:release/dev16.7-preview1 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@cston cston cston approved these changes

Assignees

@gafter gafter

Labels
Approved to merge Area-Compilers Regression Urgency-Now
Projects
None yet
Milestone
16.7.P1
Development

Successfully merging this pull request may close these issues.
5 participants
@gafter @333fred @CyrusNajmabadi @cston @JoeRobich