Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI test #44141

Closed
wants to merge 2 commits into from
Closed

CI test #44141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c429d8e
test
RikkiGibson May 11, 2020
b29bf06
only warnAsError in correctness
RikkiGibson May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,6 @@ function BuildSolution() {

# The warnAsError flag for MSBuild will promote all warnings to errors. This is true for warnings
# that MSBuild output as well as ones that custom tasks output.
#
# In all cases we pass /p:TreatWarningsAsErrors=true to promote compiler warnings to errors
$msbuildWarnAsError = if ($warnAsError) { "/warnAsError" } else { "" }

# Workaround for some machines in the AzDO pool not allowing long paths (%5c is msbuild escaped backslash)
Expand Down Expand Up @@ -260,7 +258,7 @@ function BuildSolution() {
/p:UseRoslynAnalyzers=$runAnalyzers `
/p:BootstrapBuildPath=$bootstrapDir `
/p:TestTargetFrameworks=$testTargetFrameworks `
/p:TreatWarningsAsErrors=true `
/p:TreatWarningsAsErrors=$warnAsError `
/p:VisualStudioIbcSourceBranchName=$ibcSourceBranchName `
/p:VisualStudioIbcDropId=$ibcDropId `
/p:EnableNgenOptimization=$applyOptimizationData `
Expand Down
5 changes: 5 additions & 0 deletions src/Compilers/CSharp/Test/Syntax/Parsing/LocalFunctionParsingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ public class LocalFunctionParsingTests : ParsingTests
{
public LocalFunctionParsingTests(ITestOutputHelper output) : base(output) { }

#nullable enable
[Theory] [InlineData((string?)null)]
public void M1(string? s) { s.ToString(); }
#nullable restore

[Fact]
[WorkItem(13480, "https://github.com/dotnet/roslyn/issues/13480")]
public void IncompleteLocalFunc()
Expand Down