Install ErrorProne.NET analyzers #44197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gafter this is the same change you reviewed in the past. I am only resubmitting it so I can include an analyzer to help maintain this in the future. @dotnet/roslyn-compiler can I get a couple reviews here? |
|
Before starting to enforce new styles on compiler code, we need some agreement on design (is this style desirable?). Was this run by Jared? |
|
@jmarolf schedule a meeting next week and I'm happy to go through my findings regarding this set of analyzers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All diagnostics reported by the analyzers are disabled, with the exception of EPS09 which supports and enforces the code style from #43426.
Supersedes #43426