Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow module initializers in VB #44227

Merged
merged 4 commits into from
May 15, 2020
Merged

Disallow module initializers in VB #44227

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9311d6f
Error on ModuleInitializerAttribute in VB
RikkiGibson May 13, 2020
98ee993
Test ModuleInitializerAttribute on various VB declarations
RikkiGibson May 13, 2020
f9ab114
Only give diagnostics on methods
RikkiGibson May 14, 2020
daa7e2f
Don't give diagnostic on returns. Cleanup.
RikkiGibson May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Compilers/VisualBasic/Portable/Symbols/Symbol_Attributes.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
If arguments.Attribute.IsTargetAttribute(Me, AttributeDescription.SkipLocalsInitAttribute) Then
arguments.Diagnostics.Add(ERRID.WRN_AttributeNotSupportedInVB, arguments.AttributeSyntaxOpt.Location, AttributeDescription.SkipLocalsInitAttribute.FullName)
End If

If arguments.Attribute.IsTargetAttribute(Me, AttributeDescription.ModuleInitializerAttribute) Then
Copy link
Contributor

@AlekseyTs AlekseyTs May 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arguments.Attribute.IsTargetAttribute(Me, AttributeDescription.ModuleInitializerAttribute) [](start = 15, length = 90)

Should we limit this check to MethodSymbols? If I remember correctly C# ignores the attribute on anything, but a method. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that would be more consistent.

arguments.Diagnostics.Add(ERRID.WRN_AttributeNotSupportedInVB, arguments.AttributeSyntaxOpt.Location, AttributeDescription.ModuleInitializerAttribute.FullName)
End If
End Sub

''' <summary>
Expand Down
Loading