-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test netmodules containing module initializers #44228
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -778,5 +778,171 @@ namespace System.Runtime.CompilerServices { class ModuleInitializerAttribute : S | |
Assert.Null(rootModuleType.GetMember(".cctor")); | ||
}); | ||
} | ||
|
||
[ConditionalFact(typeof(WindowsDesktopOnly), Reason = ConditionalSkipReason.NetModulesNeedDesktop)] | ||
public void MultipleNetmodules() | ||
{ | ||
var moduleOptions = TestOptions.ReleaseModule.WithMetadataImportOptions(MetadataImportOptions.All); | ||
var s1 = @" | ||
using System; | ||
using System.Runtime.CompilerServices; | ||
|
||
public class A | ||
{ | ||
[ModuleInitializer] | ||
public static void M1() | ||
{ | ||
Console.Write(1); | ||
} | ||
} | ||
|
||
namespace System.Runtime.CompilerServices { public class ModuleInitializerAttribute : System.Attribute { } }"; | ||
var comp1 = CreateCompilation(s1, options: moduleOptions.WithModuleName("A"), parseOptions: s_parseOptions); | ||
comp1.VerifyDiagnostics(); | ||
var ref1 = comp1.EmitToImageReference(); | ||
CompileAndVerify(comp1, symbolValidator: validateModuleInitializer, verify: Verification.Skipped); | ||
|
||
var s2 = @" | ||
using System; | ||
using System.Runtime.CompilerServices; | ||
|
||
public class B | ||
{ | ||
[ModuleInitializer] | ||
public static void M2() | ||
{ | ||
Console.Write(2); | ||
} | ||
}"; | ||
var comp2 = CreateCompilation(s2, options: moduleOptions.WithModuleName("B"), parseOptions: s_parseOptions, references: new[] { ref1 }); | ||
comp2.VerifyDiagnostics(); | ||
var ref2 = comp2.EmitToImageReference(); | ||
CompileAndVerify(comp2, symbolValidator: validateModuleInitializer, verify: Verification.Skipped); | ||
|
||
var exeOptions = TestOptions.ReleaseExe | ||
.WithMetadataImportOptions(MetadataImportOptions.All) | ||
.WithModuleName("C"); | ||
var s3 = @" | ||
using System; | ||
|
||
public class Program | ||
{ | ||
public static void Main(string[] args) | ||
{ | ||
Console.Write(3); | ||
} | ||
}"; | ||
var comp3 = CreateCompilation(s3, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp3.VerifyDiagnostics(); | ||
CompileAndVerify(comp3, symbolValidator: validateNoModuleInitializer, expectedOutput: "3"); | ||
|
||
var s4 = @" | ||
using System; | ||
|
||
public class Program | ||
{ | ||
public static void Main(string[] args) | ||
{ | ||
new A(); | ||
new B(); | ||
Console.Write(3); | ||
} | ||
}"; | ||
var comp4 = CreateCompilation(s4, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp4.VerifyDiagnostics(); | ||
CompileAndVerify(comp4, symbolValidator: validateNoModuleInitializer, expectedOutput: "123"); | ||
|
||
var s5 = @" | ||
using System; | ||
|
||
public class Program | ||
{ | ||
public static void Main(string[] args) | ||
{ | ||
new B(); | ||
Console.Write(3); | ||
new A(); | ||
} | ||
}"; | ||
var comp5 = CreateCompilation(s5, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp5.VerifyDiagnostics(); | ||
// This order seems surprising, but is likely related to the order in which types are loaded when a method is called. | ||
CompileAndVerify(comp5, symbolValidator: validateNoModuleInitializer, expectedOutput: "213"); | ||
|
||
var s6 = @" | ||
using System; | ||
|
||
public class Program | ||
{ | ||
public static void Main(string[] args) | ||
{ | ||
new A(); | ||
Console.Write(3); | ||
} | ||
}"; | ||
var comp6 = CreateCompilation(s6, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp6.VerifyDiagnostics(); | ||
CompileAndVerify(comp6, symbolValidator: validateNoModuleInitializer, expectedOutput: "13"); | ||
|
||
var s7 = @" | ||
using System; | ||
using System.Runtime.CompilerServices; | ||
|
||
public class Program | ||
{ | ||
[ModuleInitializer] | ||
public static void Init() | ||
{ | ||
Console.Write(0); | ||
} | ||
|
||
public static void Main(string[] args) | ||
{ | ||
new B(); | ||
Console.Write(3); | ||
} | ||
}"; | ||
var comp7 = CreateCompilation(s7, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp7.VerifyDiagnostics(); | ||
CompileAndVerify(comp7, symbolValidator: validateModuleInitializer, expectedOutput: "023"); | ||
|
||
var s8 = @" | ||
using System; | ||
using System.Runtime.CompilerServices; | ||
|
||
public class Program | ||
{ | ||
[ModuleInitializer] | ||
public static void Init() | ||
{ | ||
Console.Write(0); | ||
new A(); | ||
} | ||
|
||
public static void Main(string[] args) | ||
{ | ||
new A(); | ||
new B(); | ||
Console.Write(3); | ||
} | ||
}"; | ||
var comp8 = CreateCompilation(s8, options: exeOptions, parseOptions: s_parseOptions, references: new[] { ref1, ref2 }); | ||
comp8.VerifyDiagnostics(); | ||
CompileAndVerify(comp8, symbolValidator: validateModuleInitializer, expectedOutput: "1023"); | ||
|
||
void validateModuleInitializer(ModuleSymbol module) | ||
{ | ||
Assert.Equal(MetadataImportOptions.All, ((PEModuleSymbol)module).ImportOptions); | ||
var moduleType = module.ContainingAssembly.GetTypeByMetadataName("<Module>"); | ||
Assert.NotNull(moduleType.GetMember<MethodSymbol>(".cctor")); | ||
} | ||
|
||
void validateNoModuleInitializer(ModuleSymbol module) | ||
{ | ||
Assert.Equal(MetadataImportOptions.All, ((PEModuleSymbol)module).ImportOptions); | ||
var moduleType = module.ContainingAssembly.GetTypeByMetadataName("<Module>"); | ||
Assert.Null(moduleType.GetMember<MethodSymbol>(".cctor")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Please add |
||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I think it would be good to cover scenarios when the main module of the assembly also has an initializer. #Closed |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for each compilation we want to verify whether we emit the
<Module>..cctor
#Closed