Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports not being removed from MAS files. #44230

Merged
merged 21 commits into from
May 16, 2020
Merged

Fix imports not being removed from MAS files. #44230

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bc0b404
initial
CyrusNajmabadi May 13, 2020
3164a4f
Generate #nullable
CyrusNajmabadi May 13, 2020
7cd7226
Add tests
CyrusNajmabadi May 13, 2020
5674b62
remove using
CyrusNajmabadi May 14, 2020
f8ecb16
Update src/Features/CSharp/Portable/MetadataAsSource/CSharpMetadataAs…
CyrusNajmabadi May 14, 2020
f3fc268
Merge remote-tracking branch 'upstream/master' into nullableMAS
CyrusNajmabadi May 14, 2020
45b6c2e
Add comment
CyrusNajmabadi May 14, 2020
6601df1
Simplify
CyrusNajmabadi May 14, 2020
f21590d
Filter out dynamic attribute.
CyrusNajmabadi May 14, 2020
9183eb7
Fix nullable ref type parameters.
CyrusNajmabadi May 14, 2020
6c8c3a0
Add tests
CyrusNajmabadi May 14, 2020
02c58e0
Add test for nested type
CyrusNajmabadi May 14, 2020
d9c2d61
Whitespace
CyrusNajmabadi May 14, 2020
f8de656
Fix test
CyrusNajmabadi May 15, 2020
ad2a2e1
lint
CyrusNajmabadi May 15, 2020
240bf6b
lint
CyrusNajmabadi May 15, 2020
08b7d85
Merge remote-tracking branch 'upstream/master' into nullableMAS
CyrusNajmabadi May 15, 2020
ab0f7ac
Remove param
CyrusNajmabadi May 15, 2020
bca9b9f
Fix
CyrusNajmabadi May 15, 2020
759c6cd
lint
CyrusNajmabadi May 15, 2020
31abe0c
Merge remote-tracking branch 'upstream/master' into nullableMAS
CyrusNajmabadi May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,10 @@ await GenerateAndVerifySourceAsync(metadataSource, symbolName, LanguageNames.CSh
// {CodeAnalysisResources.InMemoryAssembly}
#endregion

using System;
using System.Runtime.CompilerServices;

public class [|C|]
{{
[NativeIntegerAttribute]
public nint i;
[NativeIntegerAttribute]
public nuint i2;

public C();
Expand Down Expand Up @@ -88,8 +84,6 @@ await context.GenerateAndVerifySourceAsync("System.ValueTuple",
// System.ValueTuple.dll
#endregion

using System;
using System;
using System.Collections;

namespace System
Expand Down
3 changes: 0 additions & 3 deletions src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.VisualBasic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public async Task BracketedIdentifierSimplificationTest()
' mscorlib.v4_6_1038_0.dll
#End Region

Imports System
Imports System.Runtime.InteropServices

Namespace System
Expand Down Expand Up @@ -95,8 +94,6 @@ await context.GenerateAndVerifySourceAsync("System.ValueTuple",
' System.ValueTuple.dll
#End Region

Imports System
Imports System
Imports System.Collections

Namespace System
Expand Down
Loading