-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formatting tests for comments after line continuation #44267
Conversation
{continuation} | ||
{continuation} | ||
{continuation} | ||
{continuation} | ||
{continuation} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If people start using this new feature in VB16 then yes, since it is new there is no data. The updated converters do use this to preserve C# comments in VB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul1956 It's not super clear to me what the desired behavior here is. Can you file an issue showing the proposed formatting output, so we can compare it to the behavior we see in these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharwell I would expect the _ to align to the same place anything that wasn't an _ would. Given below
Sub Method(Optional ByVal i As Integer = 1)
Dim aa = 1 +
2 +
3
End Sub
If you hit enter after the first + before you type anything the cursor is aligned with the 2 if you type anything else except _ it continues to be aligned with the 2. Why should typing an _ change that. If you want I can clone Master and update all the formatting around _ to what I think is desired and do a PR with all the failing tests unless you have another suggestion. The issue I see with the current behavior is it is not just the lines with the _ that shift left but also the following lines. I would be OK if the _ was left justified if everything past it was aligned the way it would have been have the _ not been present.
Adds tests for scenarios derived from #38072