-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pattern variables declared under "is not" #44513
Conversation
@jcouv I think I've responded to your comments. Do you have any others? @dotnet/roslyn-compiler May I please have a second review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 1)
@dotnet/roslyn-compiler May I please have a second review? |
@dotnet/roslyn-compiler May I please have a second review? |
@dotnet/roslyn-compiler May I please have a second review of this complete implementation of one of the C# 9.0 features? Would love to get it into the upcoming preview. |
@dotnet/roslyn-compiler May I please have a second review? |
Support pattern variables declared under "is not" (#44513)
Implements dotnet/csharplang#3369
LDM notes: https://github.com/dotnet/csharplang/blob/master/meetings/2020/LDM-2020-05-06.md#discussion