-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use init-only for records and adjust binding #44582
Merged
Merged
Commits on May 27, 2020
-
Use init-only for records and adjust binding
Changes records to generate init-only properties instead of get-only, and modifies the `with` expression to treat arguments as assignments to the left-hand side, with the safety rules of object initializers (meaning init-only assignments are allowed). Also changes records to generate a Clone method and a copy constructor. The clone calls the copy constructor and the copy constructor does a memberwise copy of the instance fields of the other type. This change also tries to simplify and reuse more pieces of binding and lowering from other initializer-based forms. The with-expression is now bound as though it were an assignment to a field or member access on a call to the Clone method.
Configuration menu - View commit details
-
Copy full SHA for 13e15e1 - Browse repository at this point
Copy the full SHA 13e15e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74e8c4a - Browse repository at this point
Copy the full SHA 74e8c4aView commit details
Commits on May 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 64ebad9 - Browse repository at this point
Copy the full SHA 64ebad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8471fe - Browse repository at this point
Copy the full SHA a8471feView commit details
Commits on May 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1c7b14c - Browse repository at this point
Copy the full SHA 1c7b14cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f605e2 - Browse repository at this point
Copy the full SHA 9f605e2View commit details -
Update src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/Synt…
…hesizedRecordClone.cs Co-authored-by: Jared Parsons <jaredpparsons@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 891fd42 - Browse repository at this point
Copy the full SHA 891fd42View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd18ab7 - Browse repository at this point
Copy the full SHA bd18ab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f35beb - Browse repository at this point
Copy the full SHA 3f35bebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.