Adapt IDE to new record syntax #44880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
commented
Jun 5, 2020
| using Microsoft.CodeAnalysis.Test.Utilities; | ||
| using Roslyn.Test.Utilities; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Recommendations | ||
| { | ||
| public class DataKeywordRecommenderTests : KeywordRecommenderTests | ||
| public class RecordKeywordRecommenderTests : KeywordRecommenderTests |
There was a problem hiding this comment.
RecordKeywordRecommenderTests [](start = 17, length = 29)
📝 this file is a duplicate of ClassKeywordRecommenderTests with one or two tests added, such as typing in position nested in record.
|
Pulled in @mavasani to help out with review since we're trying to merge this today. Thanks! |
mavasani
approved these changes
Jun 5, 2020
|
@dotnet/roslyn-ide Can someone else also do a quick review as an additional sanity? |
|
@dotnet/roslyn-ide If anyone wants to take a look, please do it quick. We're aiming to get all records PRs merged by tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this removes completion for
dataand adds completion forrecords. This also fixes some other recommenders and fixers that didn't trigger on the new type syntax.Relates to #40726 (test plan)