Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges/master to features/module initializers #44963

Merged

Conversation

RikkiGibson
Copy link
Contributor

The feature branch needs to be refreshed. Creating this PR so I can have it on my radar.

CyrusNajmabadi and others added 30 commits June 1, 2020 19:32
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Co-authored-by: Jason Malinowski <jason@jason-m.com>
Add code action equivalence key validation in test framework
This change excludes src/Compilers from the analysis.
Include the workspaces and code style layers in Compilers.slnf
Remove unnecessary feature 'IOperation'
* Implement parsing for record_base_arguments.

```
record_class_base
    : class_type record_base_arguments?
    | interface_type_list
    | class_type record_base_arguments? ',' interface_type_list
    ;

record_base_arguments
    : '(' argument_list? ')'
    ;
```
sharwell and others added 26 commits June 10, 2020 15:46
Ensure we also add VB files dynamically if they weren't originally present
Add ILspSolutionProvider in lsp
Add msbuild command syntax for /reportanalyzer
This reverts commit 3ff438e.
- The language server platform is properly implementing solution close understanding for local language servers and I found that when testing their bits Roslyn would explode gloriously. Turns out shutdown and exit support just wasn't fully enabled yet.
- When the language server platform reboots language servers it re-invokes Activate and because of that Roslyn explodes because the language client has already been activated and there was previously a contract throws check on already being initialized.
- Implemented the `ShutdownAsync` target on the `InProcLanguageServer` to detach from the diagnostic service.
- Implemented the `ExitAsync` target on the `InProcLanguageServer` to properly dispose our `JsonRpc` object.
Compute and check document indices in parallel
Inline build property RoslynPortableTargetFrameworks
Code fix for CS1615 (Remove 'in' keyword)
Spellcheck should not offer the full signatures of explicit members when offering suggestions
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 0bcbd4f into features/module-initializers Jun 11, 2020
@ghost ghost deleted the merges/master-to-features/module-initializers branch June 11, 2020 22:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.