Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IEquatable<T> in record types #44994

Merged
merged 9 commits into from
Jun 11, 2020
Merged

Implement IEquatable<T> in record types #44994

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec52f37
Implement IEquatable<T> in record types
cston Jun 8, 2020
f4f8714
PR feedback
cston Jun 10, 2020
7c26785
Ignore all differences
cston Jun 10, 2020
d337c88
Merge remote-tracking branch 'upstream/release/dev16.7-preview3' into…
cston Jun 10, 2020
d246908
Report use-site diagnostics explicitly
cston Jun 10, 2020
77b87ee
Remove comment
cston Jun 10, 2020
13e4e80
More missing type tests
cston Jun 10, 2020
dbd01fc
PR feedback
cston Jun 10, 2020
6ce1611
PR feedback
cston Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Compilers/CSharp/Portable/Binder/Binder_Lookup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,6 @@ private static void LookupMembersInInterfaceOnly(
LookupMembersInInterfacesWithoutInheritance(current, GetBaseInterfaces(type, basesBeingResolved, ref useSiteDiagnostics),
name, arity, basesBeingResolved, options, originalBinder, accessThroughType, diagnose, ref useSiteDiagnostics);
}

}

private static ImmutableArray<NamedTypeSymbol> GetBaseInterfaces(NamedTypeSymbol type, ConsList<TypeSymbol> basesBeingResolved, ref HashSet<DiagnosticInfo> useSiteDiagnostics)
Expand Down
9 changes: 9 additions & 0 deletions src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol_Bases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,15 @@ private Tuple<NamedTypeSymbol, ImmutableArray<NamedTypeSymbol>> MakeDeclaredBase
}
}

if (declaration.Kind == DeclarationKind.Record)
{
var type = DeclaringCompilation.GetWellKnownType(WellKnownType.System_IEquatable_T).Construct(this);
if (baseInterfaces.IndexOf(type, SymbolEqualityComparer.AllIgnoreOptionsPlusNullableWithUnknownMatchesAny) < 0)
Copy link
Contributor

@AlekseyTs AlekseyTs Jun 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllIgnoreOptionsPlusNullableWithUnknownMatchesAny [](start = 72, length = 49)

This doesn't ignore all aspects #Closed

{
baseInterfaces.Add(type);
}
}

HashSet<DiagnosticInfo> useSiteDiagnostics = null;

if ((object)baseType != null)
Expand Down
Loading