Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IActiveStatementSpanTrackerFactory through MEF #45004

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Use IActiveStatementSpanTrackerFactory through MEF #45004

merged 2 commits into from
Jun 12, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 9, 2020

No description provided.

@sharwell sharwell requested a review from a team as a code owner June 9, 2020 21:04
tmat
tmat requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EnC service should not fetch services from workspace. It's explicitly designed to accept all of its dependencies in the constructor and not use Workspace.

@sharwell sharwell requested a review from tmat June 11, 2020 19:56
@sharwell sharwell changed the title Use IActiveStatementSpanTracker through MEF Use IActiveStatementSpanTrackerFactory through MEF Jun 11, 2020
tmat
tmat approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit c6f473f into dotnet:master Jun 12, 2020
@ghost ghost added this to the Next milestone Jun 12, 2020
@sharwell sharwell deleted the use-mef-2 branch June 12, 2020 17:12
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.7.P4
Development

Successfully merging this pull request may close these issues.
5 participants
@sharwell @tmat @CyrusNajmabadi @dibarbet @jinujoseph