Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests #45230

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Add some tests #45230

merged 1 commit into from
Jun 16, 2020

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested a review from a team as a code owner June 16, 2020 16:20
kevinsun-dev
kevinsun-dev approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@kevinsun-dev kevinsun-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, I don't see what's wrong with a few extra asserts. LGTM

@jcouv jcouv self-assigned this Jun 16, 2020
jcouv
jcouv approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@AlekseyTs AlekseyTs merged commit 64b18be into dotnet:master Jun 16, 2020
@ghost ghost added this to the Next milestone Jun 16, 2020
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@kevinsun-dev kevinsun-dev kevinsun-dev approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
16.7.P4
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekseyTs @jcouv @kevinsun-dev @dibarbet