Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove IActiveStatementSpanTracker from the MEF catalog" #45239

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

chsienki
Copy link
Contributor

This reverts commit 31a883f.

@CyrusNajmabadi
Copy link
Member

Why reverting?

@chsienki
Copy link
Contributor Author

We're seeing issues with tests in RPS. Theory is this PR, but we're testing.

@chsienki chsienki marked this pull request as ready for review June 17, 2020 18:23
@chsienki chsienki requested a review from a team as a code owner June 17, 2020 18:23
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this PR is the one causing RPS issues
Passed successfully with this revert - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/255302

@dibarbet
Copy link
Member

dibarbet commented Jun 17, 2020

FYI @sharwell , @tmat

@chsienki chsienki merged commit d04ebc2 into dotnet:master Jun 17, 2020
@ghost ghost added this to the Next milestone Jun 17, 2020
@sharwell
Copy link
Member

@chsienki Where can I find the context for this? This PR was a prerequisite for my work this coming week.

@chsienki
Copy link
Contributor Author

@sharwell We were seeing errors in EnC when running RPS tests. The specific failure was

06/14/2020 00:55:03 Coordinated Universal Time: Error : 1 :[devenv:3020] Unexpected exception: System.InvalidOperationException: Service of type 'Microsoft.CodeAnalysis.EditAndContinue.IActiveStatementSpanTrackerFactory' is required to accomplish the task but is not available from the workspace.
   at Microsoft.CodeAnalysis.Host.HostWorkspaceServices.GetRequiredService[TWorkspaceService]()
   at Microsoft.CodeAnalysis.CSharp.EditAndContinue.CSharpEditAndContinueAnalyzer.Factory.CreateLanguageService(HostLanguageServices languageServices)
   at Microsoft.CodeAnalysis.Host.Mef.MefLanguageServices.<>c__DisplayClass4_1.<.ctor>b__2()
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at System.Lazy`1.get_Value()
   at Microsoft.CodeAnalysis.Host.Mef.MefLanguageServices.GetService[TLanguageService]()
   at Microsoft.CodeAnalysis.EditAndContinue.EditAndContinueWorkspaceService.SupportsEditAndContinue(Project project)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.<CreateActiveStatementsMap>g__supportsEditAndContinue|21_0(DocumentId documentId)
   at System.Linq.ImmutableArrayExtensions.FirstOrDefault[T](ImmutableArray`1 immutableArray, Func`2 predicate)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.CreateActiveStatementsMap(ImmutableArray`1 debugInfos)
   at Microsoft.CodeAnalysis.EditAndContinue.EditSession.<GetBaseActiveStatementsAsync>d__20.MoveNext()

@chsienki chsienki deleted the revert_workspace_factory branch June 22, 2020 17:01
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants