Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call GetSyntaxRootAsync once outside loop #45289

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Call GetSyntaxRootAsync once outside loop #45289

merged 1 commit into from
Jun 19, 2020

Conversation

Youssef1313
Copy link
Member

I think this may slightly make things faster.

@CyrusNajmabadi CyrusNajmabadi merged commit 6be131e into dotnet:master Jun 19, 2020
@CyrusNajmabadi
Copy link
Member

Thanks!

@ghost ghost added this to the Next milestone Jun 19, 2020
@Youssef1313 Youssef1313 deleted the patch-4 branch June 19, 2020 06:04
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jun 19, 2020
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therzok Therzok Therzok approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.7.P4
Development

Successfully merging this pull request may close these issues.
5 participants
@Youssef1313 @CyrusNajmabadi @Therzok @dibarbet @jinujoseph