Records: override abstract inherited properties #45336

cston · 2020-06-20T05:26:43Z

For each record parameter of a record type declaration there is a corresponding public property
member whose name and type are taken from the value parameter declaration.

For a record:

A public get and init auto-property is created (see separate init accessor specification).
An inherited abstract property with matching type is overridden.
It is an error if the inherited property does not have public overridable get and init accessors.
The auto-property is initialized to the value of the corresponding primary constructor parameter.

Fixes #44618

AlekseyTs · 2020-06-21T23:48:51Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

@@ -16,15 +16,13 @@ namespace Microsoft.CodeAnalysis.CSharp.Symbols
    internal sealed class SynthesizedRecordPropertySymbol : SourceOrRecordPropertySymbol


SynthesizedRecordPropertySymbol [](start = 26, length = 31)

It looks like changes made in this file are going to conflict with #44883 #Closed

AlekseyTs · 2020-06-21T23:50:38Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs


            public override int Arity => 0;

            public override bool IsExtensionMethod => false;

-            public override bool HidesBaseMethodsByName => false;
+            public override bool HidesBaseMethodsByName => false; // PROTOTYPE: Should this be true if it hides?


// PROTOTYPE: Should this be true if it hides? [](start = 66, length = 46)

This PR is targeting master, no PROTOTYPE comments allowed. Also, I believe C# never hides by name. #Closed

AlekseyTs · 2020-06-21T23:54:06Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

+
+            public override TypeWithAnnotations ReturnTypeWithAnnotations => _property.TypeWithAnnotations;
+
+            public override ImmutableArray<ParameterSymbol> Parameters => _property.Parameters; // PROTOTYPE: Shouldn't the parameters be owned by this symbol?


// PROTOTYPE: Shouldn't the parameters be owned by this symbol? [](start = 96, length = 63)

Yes, they should be. I think #44883 addresses that. #Closed

Will merge #44883 when that has been committed.

In reply to: 443269323 [](ancestors = 443269323)

AlekseyTs · 2020-06-22T00:03:12Z

src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs

-                        existingOrAddedMembers.Add(prop);
+                        if (isInherited && existingMember.IsAbstract)
+                        {
+                            addProperty(new SynthesizedRecordPropertySymbol(this, param, isOverride: true, diagnostics));


addProperty(new SynthesizedRecordPropertySymbol(this, param, isOverride: true, diagnostics)); [](start = 28, length = 93)

It doesn't look like we are properly inheriting custom modifiers for the property and the accessors. We should do what is done for regular properties and their accessors. #Closed

Added a test for now, and will wait for #44883.

In reply to: 443270124 [](ancestors = 443270124)

AlekseyTs · 2020-06-22T00:04:23Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

+
+            public GetAccessorSymbol(SynthesizedRecordPropertySymbol property, string paramName) : base(property)
+            {
+                Name = SourcePropertyAccessorSymbol.GetAccessorName(


Name [](start = 16, length = 4)

In case of an override, shouldn't we inherit the name of the accessor? #Closed

AlekseyTs · 2020-06-22T00:04:39Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

            {
-                _property = property;
                Name = SourcePropertyAccessorSymbol.GetAccessorName(


Name [](start = 16, length = 4)

In case of an override, shouldn't we inherit the name of the accessor? #Closed

AlekseyTs · 2020-06-22T00:08:38Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+    public abstract object P5 { init; }
+    public abstract object P6 { set; }
+}
+record B(object P1, object P2, object P3, object P4, object P5, object P6) : A;


object [](start = 9, length = 6)

Are we testing scenario with a type mismatch? #Closed

AlekseyTs · 2020-06-22T00:09:18Z

Done with review pass (iteration 1) #Closed

AlekseyTs · 2020-06-22T02:31:50Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

@@ -98,46 +97,42 @@ internal sealed class SynthesizedRecordPropertySymbol : SourceOrRecordPropertySy

        public override SyntaxList<AttributeListSyntax> AttributeDeclarationSyntaxList => new SyntaxList<AttributeListSyntax>();

-        private sealed class GetAccessorSymbol : SynthesizedInstanceMethodSymbol
+        private abstract class AccessorSymbol : SynthesizedInstanceMethodSymbol


AccessorSymbol [](start = 31, length = 14)

See also #44883 (comment), this might make it easier to deal with overriding. #Closed

AlekseyTs · 2020-06-22T19:04:40Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+  IL_0033:  add
+  IL_0034:  ret
+}");
+        }


} [](start = 8, length = 1)

It might worth testing scenario when an abstract property gets shadowed in the intermediate base by some other member with the same name. #Closed

Added a test but avoided overriding because the intermediate base members result in errors.

In reply to: 443766696 [](ancestors = 443766696)

AlekseyTs · 2020-06-23T02:30:04Z

        internal override bool HasSpecialName => _property.HasSpecialName;

I think this should always be true. There is really no relationship like that betwee a property and an accessor., I believe. #Closed

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:145 in d1f9199. [](commit_id = d1f9199, deletion_comment = False)

AlekseyTs · 2020-06-23T02:31:12Z

internal sealed class SynthesizedRecordEqualityContractProperty : PropertySymbol

It looks like there are the same issues around custom modifiers for an override case. #Closed

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:15 in d1f9199. [](commit_id = d1f9199, deletion_comment = False)

AlekseyTs · 2020-06-23T02:32:19Z

        public override ImmutableArray<ParameterSymbol> Parameters => _property.Parameters;

Same problem as with other accessor types #Closed

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:117 in d1f9199. [](commit_id = d1f9199, deletion_comment = False)

AlekseyTs · 2020-06-23T02:34:39Z

        internal override CallingConvention CallingConvention => CallingConvention.HasThis;

In one place this type is generalized, in others it is not. For example, is this correct for a static acessor? #Closed

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:155 in d1f9199. [](commit_id = d1f9199, deletion_comment = False)

AlekseyTs · 2020-06-23T04:42:04Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+                "System.Object B.P1 { get; init; }",
+                "System.Object B.P2 { get; init; }",
+                "System.Object B.P3 { get; init; }",
+                "System.Object B.P4 { get; init; }",


System.Object B.P4 { get; init; } [](start = 17, length = 33)

Where P3 and P4 came from? #Closed

AlekseyTs · 2020-06-23T04:42:30Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+            var expectedMembers = new[]
+            {
+                "System.Type B.EqualityContract { get; }",
+                "System.Object B.P1 { get; init; }",


System.Object [](start = 17, length = 13)

Should this be string? #Closed

AlekseyTs · 2020-06-23T04:42:47Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+            {
+                "System.Type B.EqualityContract { get; }",
+                "System.Object B.P1 { get; init; }",
+                "System.Object B.P2 { get; init; }",


System.Object [](start = 17, length = 13)

Should this be string? #Closed

AlekseyTs · 2020-06-23T04:46:00Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+                // (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.X.init'
+                // record C(object X, object Y) : B;
+                Diagnostic(ErrorCode.ERR_UnimplementedAbstractMethod, "C").WithArguments("C", "A.X.init").WithLocation(12, 8),
+                // (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.Y.init'


// (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.Y.init' [](start = 16, length = 84)

It looks like a duplicate error is reported. #Closed

This error is for A.Y.init, the previous error is for A.X.init.

In reply to: 443958403 [](ancestors = 443958403)

AlekseyTs · 2020-06-23T04:46:23Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+                // (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.X.get'
+                // record C(object X, object Y) : B;
+                Diagnostic(ErrorCode.ERR_UnimplementedAbstractMethod, "C").WithArguments("C", "A.X.get").WithLocation(12, 8),
+                // (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.Y.get'


// (12,8): error CS0534: 'C' does not implement inherited abstract member 'A.Y.get' [](start = 16, length = 83)

Here is another one #Closed

AlekseyTs · 2020-06-23T04:49:54Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+@"record B(object P) : A;";
+            var comp = CreateCompilation(sourceB, new[] { refA }, parseOptions: TestOptions.RegularPreview);
+            comp.VerifyDiagnostics();
+


Can we execute and observe that runtime considers things implemented by property in B? #Closed

AlekseyTs · 2020-06-23T04:52:42Z

src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordPropertySymbol.cs

-            public override ImmutableArray<TypeWithAnnotations> TypeArgumentsWithAnnotations => ImmutableArray<TypeWithAnnotations>.Empty;
-
-            public override ImmutableArray<TypeParameterSymbol> TypeParameters => ImmutableArray<TypeParameterSymbol>.Empty;
-
            public override ImmutableArray<ParameterSymbol> Parameters => ImmutableArray.Create(SynthesizedParameterSymbol.Create(


SynthesizedParameterSymbol.Create [](start = 96, length = 33)

Every time allocating a new parameter. #Closed

This was not part of this PR and has changed in #44883.

In reply to: 443960042 [](ancestors = 443960042)

AlekseyTs · 2020-06-23T04:54:54Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+  .property instance object modopt(uint16) P()
+  {
+    .get instance object modopt(uint16) A::get_P()
+    .set instance void modreq(System.Runtime.CompilerServices.IsExternalInit) A::set_P(object modopt(uint16))


modreq(System.Runtime.CompilerServices.IsExternalInit) [](start = 23, length = 55)

Please add a modopt here in addition to the modreq. In definition too. #Closed

AlekseyTs · 2020-06-23T05:01:06Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+                {
+                    var parameterType = setMethod.Parameters[0].TypeWithAnnotations;
+                    Assert.True(setMethod.OverriddenMethod.Parameters[0].TypeWithAnnotations.Equals(parameterType, TypeCompareKind.ConsiderEverything));
+                    AssertEx.Equal(expectedModifiers, parameterType.CustomModifiers);


AssertEx.Equal(expectedModifiers, parameterType.CustomModifiers); [](start = 20, length = 65)

Should also assert modifiers on return type. #Closed

AlekseyTs · 2020-06-23T05:01:33Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+            var sourceB =
+@"record B(object P) : A;";
+            var comp = CreateCompilation(sourceB, new[] { refA }, parseOptions: TestOptions.RegularPreview);
+            comp.VerifyDiagnostics();


comp.VerifyDiagnostics(); [](start = 12, length = 25)

Can we execute and observe that runtime considers things implemented by property in B? #Closed

AlekseyTs · 2020-06-27T16:50:10Z

Done with review pass (iteration 15), tests are not looked at. #Closed

AlekseyTs · 2020-06-27T17:00:10Z

src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertySymbolBase.cs

+            string name,
+            Location location,
+            TypeWithAnnotations typeOpt,
+            ImmutableArray<ParameterSymbol> parametersOpt,


parametersOpt [](start = 44, length = 13)

This could either be empty, or default. Consider passing a boolean "hasParameters" instead. #Closed

IsDefault captures that.

In reply to: 446545495 [](ancestors = 446545495)

IsDefault captures that.

Why give an illusion that you can pass a non-empty array?

In reply to: 446549153 [](ancestors = 446549153,446545495)

We don't often allow a default value for Parameters.

In reply to: 446555527 [](ancestors = 446555527,446549153,446545495)

We don't often allow a default value for Parameters.

Sorry, I am not following. Let me rephrase the question. Why use an array type to communicate a boolean state? Things simply wouldn't work properly if one passes an array with actual parameter symbols in it. No one makes sure the symbols would be linked properly. So, why give consumer an illusion that the constructor can properly deal with the situation?

In reply to: 446569515 [](ancestors = 446569515,446555527,446549153,446545495)

Makes sense, thanks.

In reply to: 446582904 [](ancestors = 446582904,446569515,446555527,446549153,446545495)

cston · 2020-06-27T18:30:22Z

internal sealed class SynthesizedRecordEqualityContractProperty : PropertySymbol

There are minimal changes to this file, some of which are responses to earlier comments.

In reply to: 650563133 [](ancestors = 650563133)

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:15 in 63b0dae. [](commit_id = 63b0dae, deletion_comment = False)

AlekseyTs · 2020-06-27T18:49:07Z

internal sealed class SynthesizedRecordEqualityContractProperty : PropertySymbol

There are minimal changes to this file, some of which are responses to earlier comments.

This is all throw away work, I am going to rewrite this anyway. Up to you.

In reply to: 650598383 [](ancestors = 650598383,650563133)

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:15 in 63b0dae. [](commit_id = 63b0dae, deletion_comment = False)

AlekseyTs · 2020-06-27T18:57:31Z

        internal override bool HasSpecialName => _property.HasSpecialName;

I think this should always be true. There is really no relationship like that between a property and an accessor., I believe.

It doesn't look like the change went for the better.

In reply to: 647868847 [](ancestors = 647868847)

Refers to: src/Compilers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs:145 in d1f9199. [](commit_id = d1f9199, deletion_comment = False)

AlekseyTs · 2020-06-28T00:57:30Z

src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs

-
-                        builder.InstanceInitializersForRecordDeclarationWithParameters.Insert(addedCount, new FieldOrPropertyInitializer.Builder(property.BackingField, paramList.Parameters[param.Ordinal]));
-                        addedCount++;
+                        addProperty(property);
                    }
                    else if (existingMember is PropertySymbol { IsStatic: false, GetMethod: { } } prop


GetMethod: { } [](start = 81, length = 14)

The current specification, that I think should be up to date given the time when the #44618 was created, and the rules stated in the issue disagree.

The issue:

For each record parameter of a record type declaration there is a corresponding public property member whose name and type are taken from the value parameter declaration. If no concrete (i.e. non-abstract) property with a get accessor and with this name and type is explicitly declared or inherited, it is produced by the compiler as follows:

For a record struct or a record class:

A public get and init auto-property is created (see separate init accessor specification). Its value is initialized during construction with the value of the corresponding primary constructor parameter. Each "matching" inherited abstract property's get accessor is overridden.

The specification:

A public get and init auto-property is created (see separate init accessor specification). Each "matching" inherited abstract accessor is overridden. The auto-property is initialized to the value of the corresponding primary constructor parameter.
For each record parameter of a record type declaration there is a corresponding public property member whose name and type are taken from the value parameter declaration.

For a record:

A public get and init auto-property is created (see separate init accessor specification). Each "matching" inherited abstract accessor is overridden. The auto-property is initialized to the value of the corresponding primary constructor parameter.

Could you please reconcile the differences? This is not blocking

#Resolved

AlekseyTs · 2020-06-28T01:10:54Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

@@ -3227,15 +3230,15 @@ public void Inheritance_08()
 }";
            var comp = CreateCompilation(source);
            comp.VerifyDiagnostics(
-                // (11,8): error CS0534: 'C' does not implement inherited abstract member 'B.Y.get'
+                // (11,14): error CS0546: 'C.X.init': cannot override because 'A.X' does not have an overridable set accessor


// (11,14): error CS0546: 'C.X.init': cannot override because 'A.X' does not have an overridable set accessor [](start = 16, length = 109)

It doesn't look like this error follows specification from the #44618.

It says:

Each "matching" inherited abstract property's get accessor is overridden.

However it doesn't say anything about init/set accessors. From reading the specification I am getting an impression that we shouldn't be reporting an error for this scenario, we override the getter and leave the init accessor not overriding anything. This, however, isn't something that you can express in a regular C# today. So, it would make sense to not support this for synthesized properties as well. Please, include amended specification in the description of this PR, so that reviewers could review against it. #Resolved

AlekseyTs · 2020-06-28T01:26:04Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+    {
+        B b = new B(3);
+        WriteLine(b.P);
+        WriteLine(((A)b).P);


WriteLine(((A)b).P); [](start = 8, length = 20)

It doesn't look like we are exercising overriding of the setter #Closed

AlekseyTs · 2020-06-28T01:26:21Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+    {
+        B b = new B(3);
+        WriteLine(b.P);
+        WriteLine(((A)b).P);


WriteLine(((A)b).P); [](start = 8, length = 20)

It doesn't look like we are exercising overriding of the setter #Closed

AlekseyTs · 2020-06-28T01:27:48Z

src/Compilers/CSharp/Test/Semantic/Semantics/RecordTests.cs

+    {
+        B b = new B(3);
+        WriteLine(b.P);
+        WriteLine(((A)b).P);


WriteLine(((A)b).P); [](start = 8, length = 20)

It doesn't look like we are exercising overriding of the setter #Closed

AlekseyTs · 2020-06-28T01:36:10Z

Done with review pass (iteration 17)

AlekseyTs

LGTM (iteration 20)

cston · 2020-06-30T15:38:13Z

@dotnet/roslyn-compiler, please review.

RikkiGibson · 2020-06-30T19:26:30Z

...ers/CSharp/Portable/Symbols/Synthesized/Records/SynthesizedRecordEqualityContractProperty.cs

@@ -144,7 +147,7 @@ public GetAccessorSymbol(SynthesizedRecordEqualityContractProperty property)

            public override ImmutableHashSet<string> ReturnNotNullIfParameterNotNull => ImmutableHashSet<string>.Empty;

-            internal override bool HasSpecialName => _property.HasSpecialName;
+            internal override bool HasSpecialName => true;


I don't understand this change, doesn't this correspond to the 'rtspecialname' metadata flag? #ByDesign

HasSpecialName corresponds to the specialname metadata bit. Property accessors should set that bit.

In reply to: 447926980 [](ancestors = 447926980)

Records: override abstract inherited properties

e22ea5e

cston requested a review from a team as a code owner June 20, 2020 05:26

cston added Area-Compilers New Language Feature - Records Records labels Jun 20, 2020

AlekseyTs reviewed Jun 21, 2020

View reviewed changes

AlekseyTs reviewed Jun 22, 2020

View reviewed changes

cston added 2 commits June 22, 2020 13:19

PR feedback

e065ff0

Add test

d1f9199

AlekseyTs reviewed Jun 23, 2020

View reviewed changes

Replace delegate parameters

7a0481b

AlekseyTs reviewed Jun 27, 2020

View reviewed changes

PR feedback

697f85f

cston requested a review from a team June 27, 2020 21:32

HasSpecialName

5d5316b

AlekseyTs reviewed Jun 28, 2020

View reviewed changes

cston added 3 commits June 27, 2020 18:40

PR feedback

7f6fd4b

Merge remote-tracking branch 'upstream/master' into 44618

f852cf0

Misc.

f29f2f8

cston requested a review from a team June 29, 2020 17:01

jcouv self-assigned this Jun 29, 2020

AlekseyTs approved these changes Jun 29, 2020

View reviewed changes

AlekseyTs mentioned this pull request Jun 30, 2020

Add support for "data" properties #44883

Closed

RikkiGibson reviewed Jun 30, 2020

View reviewed changes

RikkiGibson approved these changes Jun 30, 2020

View reviewed changes

cston merged commit 4b1eac5 into dotnet:master Jun 30, 2020

ghost added this to the Next milestone Jun 30, 2020

cston deleted the 44618 branch June 30, 2020 20:12

JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020

		@@ -16,15 +16,13 @@ namespace Microsoft.CodeAnalysis.CSharp.Symbols
		internal sealed class SynthesizedRecordPropertySymbol : SourceOrRecordPropertySymbol


		public override TypeWithAnnotations ReturnTypeWithAnnotations => _property.TypeWithAnnotations;

		public override ImmutableArray<ParameterSymbol> Parameters => _property.Parameters; // PROTOTYPE: Shouldn't the parameters be owned by this symbol?

Records: override abstract inherited properties #45336

Records: override abstract inherited properties #45336

Conversation

cston commented Jun 20, 2020 • edited Loading

AlekseyTs Jun 21, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 21, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs commented Jun 22, 2020 • edited Loading

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekseyTs commented Jun 23, 2020 • edited Loading

AlekseyTs commented Jun 23, 2020 • edited Loading

AlekseyTs commented Jun 23, 2020 • edited Loading

AlekseyTs commented Jun 23, 2020 • edited Loading

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs commented Jun 27, 2020 • edited Loading

AlekseyTs Jun 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cston commented Jun 27, 2020

AlekseyTs commented Jun 27, 2020

AlekseyTs commented Jun 27, 2020

AlekseyTs Jun 28, 2020 • edited by cston Loading

Choose a reason for hiding this comment

AlekseyTs Jun 28, 2020 • edited by cston Loading

Choose a reason for hiding this comment

AlekseyTs Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs Jun 28, 2020 • edited Loading

Choose a reason for hiding this comment

AlekseyTs commented Jun 28, 2020

AlekseyTs left a comment

Choose a reason for hiding this comment

cston commented Jun 30, 2020

RikkiGibson Jun 30, 2020 • edited by cston Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cston commented Jun 20, 2020 •

edited

Loading

AlekseyTs Jun 21, 2020 •

edited

Loading

AlekseyTs Jun 21, 2020 •

edited

Loading

AlekseyTs Jun 21, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs commented Jun 22, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs Jun 22, 2020 •

edited

Loading

AlekseyTs commented Jun 23, 2020 •

edited

Loading

AlekseyTs commented Jun 23, 2020 •

edited

Loading

AlekseyTs commented Jun 23, 2020 •

edited

Loading

AlekseyTs commented Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs Jun 23, 2020 •

edited

Loading

AlekseyTs commented Jun 27, 2020 •

edited

Loading

AlekseyTs Jun 27, 2020 •

edited

Loading

AlekseyTs Jun 28, 2020 •

edited by cston

Loading

AlekseyTs Jun 28, 2020 •

edited by cston

Loading

AlekseyTs Jun 28, 2020 •

edited

Loading

AlekseyTs Jun 28, 2020 •

edited

Loading

AlekseyTs Jun 28, 2020 •

edited

Loading

RikkiGibson Jun 30, 2020 •

edited by cston

Loading