-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to features/module-initializers #45410
Merged
28 commits merged into
features/module-initializers
from
merges/master-to-features/module-initializers
Jun 24, 2020
Merged
Merge master to features/module-initializers #45410
28 commits merged into
features/module-initializers
from
merges/master-to-features/module-initializers
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IParameterSymbol.DeclaringSyntaxReferences will be empty if the analyzed method call is targeting a method with no source code available (external assembly).
…reAsNullableCodeFixTests.cs
…reAsNullableCodeFixTests.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
Support FieldDeclarationSyntax in CS8618 fixer
Enable DateTime completion in string interpolation format strings.
This reverts commit d04ebc2.
Remove IActiveStatementSpanTracker from the MEF catalog
* Binder Check for Unbound Generics in Methods * Edited Tests to Match Changes * Update Binder_Expressions.cs * Restricted Error Scope, allowed other binding errors to occur * Update Binder_Expressions.cs * Modified location and error reporting * Quick PR Fixes - Part 1 of 2 * Quick PR Fixes - Part 2 of 2 Added new error, broadened error throwing to include all instances of OmittedTypeArgument in method binding. * Update GenericConstraintTests.cs * Added VB tests, extended C# tests
Add API review notes for d16.7
Fix exception in declare-as-nullable code fix
ghost
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
ghost
deleted the
merges/master-to-features/module-initializers
branch
June 24, 2020 02:36
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/module-initializers.
git fetch --all git checkout merges/master-to-features/module-initializers git reset --hard upstream/features/module-initializers git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/module-initializers --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.