Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete UnitTesting external access APIs #45553

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Remove obsolete UnitTesting external access APIs #45553

merged 1 commit into from
Jul 2, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 30, 2020

No description provided.

@tmat tmat requested a review from a team as a code owner June 30, 2020 02:28
@tmat
Copy link
Member Author

tmat commented Jun 30, 2020

@shyamnamboodiripad @Cosifne PTAL

@tmat tmat added the Area-IDE label Jun 30, 2020
@Cosifne
Copy link
Member

Cosifne commented Jun 30, 2020

LGTM but I found one missing obsolete API in test impact.
I have a PR to remove it. So it would better to merge in this PR after this https://github.com/dotnet/testimpact/pull/2942

@tmat
Copy link
Member Author

tmat commented Jun 30, 2020

@Cosifne Can you ping me here when that PR is merged and inserted to VS?

@tmat tmat merged commit ec72c14 into dotnet:master Jul 2, 2020
@ghost ghost added this to the Next milestone Jul 2, 2020
@tmat tmat deleted the RemoveObsoleteUnitTestingApis branch July 2, 2020 18:07
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@Cosifne Cosifne Cosifne approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
16.8.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @Cosifne @CyrusNajmabadi @JoeRobich