Handle invalid dotnet_diagnostic entry without ID part in configurati… #45615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
commented
Jul 2, 2020
| @@ -488,10 +488,13 @@ private async Task<Solution> ConfigureAsync() | |||
| key.EndsWith(SeveritySuffix, StringComparison.Ordinal)) | |||
| { | |||
| var diagIdLength = key.Length - (DiagnosticOptionPrefix.Length + SeveritySuffix.Length); | |||
| var diagId = key.Substring(DiagnosticOptionPrefix.Length, diagIdLength); | |||
| if (string.Equals(diagId, _diagnostic.Id, StringComparison.OrdinalIgnoreCase)) | |||
| if (diagIdLength > 0) | |||
There was a problem hiding this comment.
Only change is adding this if check.
jasonmalinowski
approved these changes
Jul 2, 2020
allisonchou
approved these changes
Jul 2, 2020
|
Thanks! |
ghost
merged commit 
|
Does this fix the specific issue? The problem is occurring when the specified line is included in the .editorconfig file (note the leading '#'):
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on code fix
Fixes #45446