Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code analysis messages in command-line parser #45638

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Fix code analysis messages in command-line parser #45638

merged 4 commits into from
Jul 14, 2020

Conversation

davkean
Copy link
Member

@davkean davkean commented Jul 3, 2020

Some quick cleanup in command-line parser.

@davkean davkean requested a review from a team as a code owner July 3, 2020 01:54
@sharwell sharwell added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 8, 2020
@davkean
Copy link
Member Author

davkean commented Jul 13, 2020

@dotnet/roslyn-compiler Going to merge thsi in tomorrow; please tell if you have any concerns.

@RikkiGibson
Copy link
Contributor

Is this just cleanup or are there observable behavior changes from this PR?

@davkean
Copy link
Member Author

davkean commented Jul 13, 2020

@RikkiGibson There is/should be no obserable behavior changes.

@AlekseyTs
Copy link
Contributor

@davkean

Going to merge thsi in tomorrow; please tell if you have any concerns.

For changes under Compilers, a PR has to have two sign-off from the compiler team before it can be merged. Please follow the policy.

gafter
gafter approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@gafter gafter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😷

jcouv
jcouv approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@jcouv jcouv self-assigned this Jul 13, 2020
@davkean davkean merged commit 0535a47 into dotnet:master Jul 14, 2020
@ghost ghost added this to the Next milestone Jul 14, 2020
@davkean davkean deleted the CommandLineArgs branch July 14, 2020 00:01
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gafter gafter gafter approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.8.P1
Development

Successfully merging this pull request may close these issues.
7 participants
@davkean @RikkiGibson @AlekseyTs @gafter @jcouv @JoeRobich @sharwell