Add some tests from records test plan #46466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
reviewed
Jul 31, 2020
| } | ||
| "; | ||
| var comp = CreateCompilation(new[] { src, IsExternalInitTypeDefinition }, options: TestOptions.DebugExe, parseOptions: TestOptions.RegularPreview); | ||
| comp.VerifyDiagnostics(); |
There was a problem hiding this comment.
.VerifyDiagnostics() [](start = 16, length = 20)
Consider calling VarifyDiagnostics on result of CompileAndVerify. That set will include any warnings that might be reported by emit phase.
AlekseyTs
reviewed
Jul 31, 2020
| } | ||
| "; | ||
| CreateCompilation(src).VerifyDiagnostics( | ||
| // (2,1): error CS0267: The 'partial' modifier can only appear immediately before 'class', 'struct', 'interface', or 'void' |
There was a problem hiding this comment.
before 'class', 'struct', 'interface', or 'void' [](start = 91, length = 48)
Is this list adjusted in another PR?
There was a problem hiding this comment.
Yes. I'm merged master into this PR and updated the comment now.
|
Since this PR contains no product code change (test and updating a resource string), I'll go ahead and merge with a single review once CI is green. Thanks |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #40726 (test plan for records)