Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to obsolete class #47260

Merged
4 commits merged into from
Aug 30, 2020
Merged

Remove reference to obsolete class #47260

4 commits merged into from
Aug 30, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 29, 2020

The master has a build error after merging #47222 due to the obsolete InitializationContext in this test class.

Just curious how the CI build passed in the PR, then failed on master? Figured it out. ;-)

@Youssef1313 Youssef1313 requested a review from a team as a code owner August 29, 2020 20:07
@Youssef1313 Youssef1313 requested a review from a team as a code owner August 29, 2020 20:13
@Youssef1313 Youssef1313 changed the title Remove unused reference to obsolete class Remove reference to obsolete class Aug 29, 2020
@333fred
Copy link
Member

333fred commented Aug 29, 2020

@chsienki please take a look.

@333fred 333fred requested a review from chsienki August 29, 2020 20:24
@Youssef1313 Youssef1313 marked this pull request as draft August 29, 2020 20:50
@Youssef1313 Youssef1313 marked this pull request as ready for review August 29, 2020 20:51
@chsienki
Copy link
Contributor

Woops, good catch. Thanks @Youssef1313 !

@ghost
Copy link

ghost commented Aug 29, 2020

Hello @333fred!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit d12d0ef into dotnet:master Aug 30, 2020
@ghost ghost added this to the Next milestone Aug 30, 2020
@333fred
Copy link
Member

333fred commented Aug 30, 2020

Thanks @Youssef1313!

@Youssef1313 Youssef1313 deleted the patch-25 branch August 30, 2020 11:17
@allisonchou allisonchou modified the milestones: Next, 16.8.P3 Aug 31, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants