-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct feature name for error message #47518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 7)
@@ -6565,9 +6565,9 @@ static void Ok() | |||
"; | |||
var comp = CreateCompilation(source, parseOptions: TestOptions.Regular6); | |||
comp.VerifyDiagnostics( | |||
// (6,9): error CS8059: Feature 'tuples' is not available in C# 6. Please use language version 7.0 or greater. | |||
// (6,9): error CS8059: Feature 'discards' is not available in C# 6. Please use language version 7.0 or greater. | |||
// _ = M(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ = M(); [](start = 27, length = 8)
This comment looks incorrect.
Many integration tests are failling:
and MUCH MUCH more. This is very unusual. Can someone check what's going on before restarting the failing jobs? |
My understanding is that once an integration test fails, the subsequent integration tests in a run do not have trustworthy results. /cc @sharwell |
@RikkiGibson Tests are failing in #47497 and #47516 too. Also in 7b7c5ef. Giving a quick look to master, I think the first failure for this integration tests happened in 38c8b16 (However, the changes in this commit seems unrelated 😄) They occurs very frequently, but not consistently. |
@RikkiGibson I think @sharwell is taking care of these integration tests failures. You can re-run the failed jobs and it should be ready to merge if integration tests passed. |
Merged/squashed. Thanks @Youssef1313 ! |
Fixes #47280