Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct feature name for error message #47518

Merged
merged 8 commits into from
Sep 11, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 7, 2020

Fixes #47280

@Youssef1313 Youssef1313 requested a review from a team as a code owner September 7, 2020 22:19
@Youssef1313 Youssef1313 marked this pull request as draft September 8, 2020 09:01
@Youssef1313 Youssef1313 marked this pull request as ready for review September 8, 2020 09:01
@jcouv jcouv added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Sep 8, 2020
@jcouv jcouv self-assigned this Sep 8, 2020
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 7)

@@ -6565,9 +6565,9 @@ static void Ok()
";
var comp = CreateCompilation(source, parseOptions: TestOptions.Regular6);
comp.VerifyDiagnostics(
// (6,9): error CS8059: Feature 'tuples' is not available in C# 6. Please use language version 7.0 or greater.
// (6,9): error CS8059: Feature 'discards' is not available in C# 6. Please use language version 7.0 or greater.
// _ = M();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ = M(); [](start = 27, length = 8)

This comment looks incorrect.

@Youssef1313
Copy link
Member Author

Many integration tests are failling:

  • VerifyPreviousAndNextHistory
  • AddAssemblyReferenceAndTypesToInteractive
  • Backspace
  • BackspaceBehavesLikeDelete

and MUCH MUCH more. This is very unusual. Can someone check what's going on before restarting the failing jobs?

@RikkiGibson
Copy link
Contributor

My understanding is that once an integration test fails, the subsequent integration tests in a run do not have trustworthy results. /cc @sharwell

@Youssef1313
Copy link
Member Author

Youssef1313 commented Sep 9, 2020

@RikkiGibson Tests are failing in #47497 and #47516 too.

Also in 7b7c5ef.

Giving a quick look to master, I think the first failure for this integration tests happened in 38c8b16 (However, the changes in this commit seems unrelated 😄)

They occurs very frequently, but not consistently.

@Youssef1313
Copy link
Member Author

@RikkiGibson I think @sharwell is taking care of these integration tests failures. You can re-run the failed jobs and it should be ready to merge if integration tests passed.

@jcouv jcouv merged commit 91e9498 into dotnet:master Sep 11, 2020
@ghost ghost added this to the Next milestone Sep 11, 2020
@jcouv
Copy link
Member

jcouv commented Sep 11, 2020

Merged/squashed. Thanks @Youssef1313 !

@Youssef1313 Youssef1313 deleted the patch-32 branch September 11, 2020 05:45
@dibarbet dibarbet modified the milestones: Next, 16.8.P4 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor diagnostic for out discards in lang version 6
5 participants