Reduce allocation from data taken in local performance trace #48896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo_Serialization.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sharwell
commented
Oct 25, 2020
jaredpar
reviewed
Oct 26, 2020
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo.Node.cs
Show resolved
Hide resolved
sharwell
force-pushed
the
reduce-allocs
branch
from
b19a0ad to
a9609cc
Compare
|
@CyrusNajmabadi @jaredpar this is now cleaned up and rebased. The only content changes in the rebase were the final two commits, which can be reviewed per-commit. @dotnet/roslyn-compiler I will need a second review here in addition to the one from Jared. |
AlekseyTs
reviewed
Oct 27, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlekseyTs
reviewed
Oct 27, 2020
This comment has been minimized.
This comment has been minimized.
sharwell
force-pushed
the
reduce-allocs
branch
from
9998a11 to
719655c
Compare
AlekseyTs
approved these changes
Oct 27, 2020
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Oct 27, 2020
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/TemporaryArray`1.cs
Show resolved
Hide resolved
sharwell
force-pushed
the
reduce-allocs
branch
from
58904a1 to
9609d50
Compare
|
@jaredpar This just needs a final sign-off from you now |
jaredpar
approved these changes
Oct 28, 2020
ghost
added this to the
This was referenced Oct 28, 2020
alrz
reviewed
Jul 4, 2023
| /// <typeparam name="T">The type of elements stored in the collection.</typeparam> | ||
| [NonCopyable] | ||
| [StructLayout(LayoutKind.Sequential)] | ||
| internal struct TemporaryArray<T> : IDisposable |
There was a problem hiding this comment.
@sharwell I'm wondering if it is at all possible / preferable to use InlineArray for this?
There was a problem hiding this comment.
@alrz InlineArray wouldn't be a complete replacement for this, but it would certainly be a viable replacement for the _item0..._item3 fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can separate refactoring 7e6b174 if desired.