Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly record the dispose method to be invoked in operations #49481

Merged
merged 26 commits into from
Dec 8, 2020
Merged

Correctly record the dispose method to be invoked in operations #49481

merged 26 commits into from
Dec 8, 2020

Commits on Nov 18, 2020

  1. Correctly record the dispose method to be invoked in operations

    @chsienki
    chsienki committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    257342a View commit details
    Browse the repository at this point in the history

  2. Fix whitespace

    @chsienki
    chsienki committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    64becc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Always populate dispose method: 

    - Always populate the dispose method in binding, even if its for I{Async}Disposable
- Remove knownToImplementIDisposable
- Just use the precalcualted dispose method in IOperation rather than calculating it
- Use the presence of the DisposeMethod to calculate the expected output in CFG
- Correctly report invalid operations in CFG
- Update tests
    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    9966c18 View commit details
    Browse the repository at this point in the history

  2. Explicitly record if we're doing pattern based disposal

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    dbaebf2 View commit details
    Browse the repository at this point in the history

  3. Remove uneeded method look up in local rewriter

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    06fd3df View commit details
    Browse the repository at this point in the history

  4. Remove comment

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    3500038 View commit details
    Browse the repository at this point in the history

  5. Remove nullable annotation + add debug.assert

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    eac0131 View commit details
    Browse the repository at this point in the history

  6. Fix VB dispose tests

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    378f453 View commit details
    Browse the repository at this point in the history

  7. Remove unused code

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    0dbc267 View commit details
    Browse the repository at this point in the history

  8. PR Feedback

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    55b486a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/features/ioperation' into fix_… 

    …cfg_pattern_dispose
    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    98cf4f0 View commit details
    Browse the repository at this point in the history

  10. Wrap long line

    @chsienki
    chsienki committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    96f3c49 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Use everything comparer

    @chsienki
    chsienki committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    8260879 View commit details
    Browse the repository at this point in the history

  2. Make dispose method internal

    @chsienki
    chsienki committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    9a36a9a View commit details
    Browse the repository at this point in the history

  3. Fix copy paste

    @chsienki
    chsienki committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    a3d5401 View commit details
    Browse the repository at this point in the history

  4. PR Feedback

    @chsienki
    chsienki committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    ab11fc7 View commit details
    Browse the repository at this point in the history

  5. Restore knownToImplentIDisposable 

    Add IsPatternDispose to foreach info
    @chsienki
    chsienki committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    89fe431 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Restore error recovery logic 

    Add more tests for VB
    @chsienki
    chsienki committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e4a2548 View commit details
    Browse the repository at this point in the history

  2. Clean up implementsIDisposable logic

    @chsienki
    chsienki committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    c58e528 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Fix formatting (again)

    @chsienki
    chsienki committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c16aff2 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. PR Feedback

    @chsienki
    chsienki committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    430214d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Fix tests

    @chsienki
    chsienki committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    af2dc06 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @chsienki
    chsienki committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    016fe90 View commit details
    Browse the repository at this point in the history

  3. Restore comments

    @chsienki
    chsienki committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5995966 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. PR Feedback

    @chsienki
    chsienki committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4410ecc View commit details
    Browse the repository at this point in the history

  2. Add test for nullable value type pattern disposal

    @chsienki
    chsienki committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    a9e8edb View commit details
    Browse the repository at this point in the history