-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Simplify interpolation' should not be suggested in VB for non-literal alignments #49717
'Simplify interpolation' should not be suggested in VB for non-literal alignments #49717
Conversation
…edge to all langs instead of using inheritance" This reverts commit 4365779.
b60a850
to
5feb730
Compare
src/Analyzers/CSharp/Analyzers/SimplifyInterpolation/CSharpHelpers.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/SimplifyInterpolation/AbstractHelpers.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/SimplifyInterpolation/AbstractHelpers.cs
Outdated
Show resolved
Hide resolved
...lBasic/Analyzers/SimplifyInterpolation/VisualBasicSimplifyInterpolationDiagnosticAnalyzer.vb
Outdated
Show resolved
Hide resolved
...sualBasic/CodeFixes/SimplifyInterpolation/VisualBasicSimplifyInterpolationCodeFixProvider.vb
Outdated
Show resolved
Hide resolved
9717e66
to
018c7aa
Compare
@sharwell Here's a case where fixing merge conflicts by merging instead of rebasing causes a situation where you really can't see what's happening at all. Do you know where the "merging is better" theory broke down in this case, so that I could have predicted it and rebased instead? |
@jnm2 if someone had already reviewed the Files Changed for 018c7aa (and marked the files as reviewed in their local view), the re-review of the complete PR (all commits) would only uncheck the items which changed in the final merge commit. Otherwise, new reviewers are looking at a fairly clean change. |
@sharwell Oh, is it something they can benefit from and I can't? I was hoping to be able to have a view of what changed within the PR files in the diff of the merge commit, but it shows me everything, way too much to be useful. |
d8f7cd8
to
543371b
Compare
I think the diff is just too big to show the condensed diff. I imagine there is a git command line feature to show the equivalent locally. |
Fixes #49712
💭 Would like to revert 4365779 and bring back abstract helper classes. That way there wouldn't now be three pieces of knowledge duplicated between the analyzers and the fix providers: 1. what conditional syntax is 2. what parenthesized syntax is 3. whether the language supports non-literal alignment components