VB init-only: Conversions in init-only phase #50770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcouv, @dotnet/roslyn-compiler Please review. |
333fred
previously approved these changes
Jan 26, 2021
|
@AlekseyTs can we re-target this to |
Done |
333fred
approved these changes
Jan 28, 2021
|
@jcouv Could you please take another look? |
1 similar comment
|
@jcouv Could you please take another look? |
|
@jaredpar Do we need to get any special sign-off to merge into release/dev16.9? |
jcouv
reviewed
Jan 28, 2021
| Select Case receiverOpt.Kind | ||
| Case BoundKind.MeReference, BoundKind.MyBaseReference, BoundKind.MyClassReference | ||
| Return True | ||
| Case BoundKind.Parenthesized |
There was a problem hiding this comment.
Looks like this fixes the handling for parenthesized receiver in With. Do we have a test for that case? #Resolved
There was a problem hiding this comment.
Looks like this fixes the handling for parenthesized receiver in With. Do we have a test for that case?
EvaluationInitOnlySetter_10
In reply to: 566277477 [](ancestors = 566277477)
jcouv
approved these changes
Jan 28, 2021
|
@jaredpar Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a VB "counterpart" of #50424.