add property bag to diagnostic and remember origin of the diagnostic #510
Conversation
this change contains 2 changes. one is adding property bag to diagnostic and the other is putting origin of the diagnostic in the property bag. the property bag is added based on users feedback. this basically lets users add a diagnostic specific information. second change is for error list. we would like to order errors better based on the origin of the errors (syntax, declaration, others and etc). two changes are together because the second one takes advantage of the property bag we just added. ... this is a port of CR I had in TFS to github. checkin is delayed due to sign off - this contains public API change.
| @@ -223,6 +267,11 @@ public bool IsWarningAsError | |||
| /// </summary> | |||
| internal virtual IReadOnlyList<string> CustomTags { get { return (IReadOnlyList<string>)this.Descriptor.CustomTags; } } | |||
|
|
|||
| /// <summary> | |||
| /// Gets property bag for the diagnostic. | |||
There was a problem hiding this comment.
Can you add a better doc comment? Maybe similar to the one in the Create method
There was a problem hiding this comment.
Will do.
-
Heejae
From: Srivatsn Narayanan [mailto:notifications@github.com]
Sent: Monday, February 16, 2015 6:32 PM
To: dotnet/roslyn
Cc: HeeJae Chang
Subject: Re: [roslyn] add property bag to diagnostic and remember origin of the diagnostic (#510)
In src/Compilers/Core/Portable/Diagnostic/Diagnostic.cshttps://github.com//pull/510#discussion_r24788937:
@@ -223,6 +267,11 @@ public bool IsWarningAsError
/// </summary> internal virtual IReadOnlyList<string> CustomTags { get { return (IReadOnlyList<string>)this.Descriptor.CustomTags; } }
/// <summary>/// Gets property bag for the diagnostic.
Can you add a better doc comment? Maybe similar to the one in the Create method
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/510/files#r24788937.
There was a problem hiding this comment.
hmm.. comment is not much different than one in the Create method, though.
|
@AnthonyDGreen As this is a public API change, you should probably review it. |
|
|
(that's the "ship-it squirrel")Conflicts: src/Features/Core/Diagnostics/EngineV1/DiagnosticIncrementalAnalyzer.cs
|
@srivatsn @AnthonyDGreen can you guys take a look and sign off? |
|
👍 |
add property bag to diagnostic and remember origin of the diagnostic
this change contains 2 changes. one is adding property bag to diagnostic and the other is putting origin of a diagnostic in the property bag.
the property bag is added based on users feedback. this basically lets users attach a diagnostic specific information to a diagnostic.
second change is for error list. we would like to order errors better based on the origin of the errors (syntax, declaration, others and etc). two changes are together because the second one takes advantage of the property bag we just added.
...
this is a port of CR I had in TFS to github. checkin is delayed due to sign off - this contains public API change.
...
related issue #509