-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split imports binder into its own binder. #51452
Split imports binder into its own binder. #51452
Conversation
This is a refactoring, no behavior change intended.
@cston, @dotnet/roslyn-compiler Please review. |
@cston, @dotnet/roslyn-compiler Please review. |
@dotnet/roslyn-compiler Please review, need a second sign-off. |
Looking. |
_current = GetNextScope(binder.Next); | ||
} | ||
// Return a scope for the next Binder that supports extension methods. | ||
_current = GetNextScope(binder.Next); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it looks like this whole if/else could be simplified to _current = GetNextScope(_current.Binder?.Next ?? _binder);
#WontFix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 2). One suggested refactoring, but that's fine as a followup.
This is a refactoring, no behavior change intended.