Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify NotNullIfParameterNotNull implementation in PEParameterSymbol #51995

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Simplify NotNullIfParameterNotNull implementation in PEParameterSymbol #51995

merged 4 commits into from
Mar 23, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 requested a review from a team as a code owner March 19, 2021 19:21
@Youssef1313 Youssef1313 mentioned this pull request Mar 19, 2021
Merged
1 task
@RikkiGibson RikkiGibson self-assigned this Mar 19, 2021
@RikkiGibson RikkiGibson added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label Mar 19, 2021
333fred
333fred approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 4), assuming tests pass. @dotnet/roslyn-compiler for a second review please.

@333fred 333fred merged commit 7becc52 into dotnet:main Mar 23, 2021
@ghost ghost added this to the Next milestone Mar 23, 2021
@333fred
Copy link
Member

333fred commented Mar 23, 2021

Thanks @Youssef1313!

@Youssef1313 Youssef1313 deleted the patch-38 branch March 23, 2021 05:42
@333fred 333fred mentioned this pull request Mar 25, 2021
Merged
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@cston cston cston approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
16.10.P2
Development

Successfully merging this pull request may close these issues.
5 participants
@Youssef1313 @333fred @RikkiGibson @cston @allisonchou