Split states for is not patterns
#52205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrz
commented
Mar 28, 2021
| @@ -52,55 +52,47 @@ private BoundExpression BindIsPatternExpression(IsPatternExpressionSyntax node, | |||
| // Note that these labels are for the convenience of the compilation of patterns, and are not necessarily emitted into the lowered code. | |||
| LabelSymbol whenTrueLabel = new GeneratedLabelSymbol("isPatternSuccess"); | |||
| LabelSymbol whenFalseLabel = new GeneratedLabelSymbol("isPatternFailure"); | |||
|
|
|||
| bool negated = pattern.IsNegated(out var innerPattern); | |||
| BoundDecisionDag decisionDag = DecisionDagBuilder.CreateDecisionDagForIsPattern( | |||
There was a problem hiding this comment.
This file is simply reverted to the state before #49369
alrz
commented
Mar 28, 2021
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_IsPatternOperator.cs
Show resolved
Hide resolved
alrz
commented
Mar 29, 2021
Comment on lines
+1374
to
+1377
| <!-- | ||
| Required is true when bindings are used in the opposite branch and cannot be optimized away. | ||
| --> | ||
| <Field Name="Required" Type="bool"/> |
There was a problem hiding this comment.
We're going to need this for or pattern bindings when we split state for those as well.
Comment on lines
6541
to
+6542
| [InlineData("!(o is (41 or 42))")] | ||
| [InlineData("o is not (41 or 42)")] | ||
| public void IsNot_11(string pattern) | ||
| public void IsNot_11a(string pattern) |
There was a problem hiding this comment.
The reason for different codegen is that for some of tests we actually use linear lowering.
|
@cston Can you please take a look, thanks. |
|
On the second thought, this isn't necessary right now and can be done as part of dotnet/csharplang#4592 later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #49369
See #49369 (comment)