-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record-structs: adjust symbol display and QuickInfo #52455
Conversation
@AlekseyTs @RikkiGibson @dotnet/roslyn-compiler for review. Thanks |
@@ -447,12 +447,14 @@ static void validateModule(ModuleSymbol module) | |||
Assert.True(point is SourceNamedTypeSymbol); | |||
Assert.True(point.IsRecordStruct); | |||
Assert.True(point.GetPublicSymbol().IsRecord); | |||
Assert.Equal("record struct Point", point.ToDisplayString(SymbolDisplayFormat.TestFormat.AddKindOptions(SymbolDisplayKindOptions.IncludeTypeKeyword))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IncludeTypeKeyword [](start = 149, length = 18)
It would be good to observe behavior without this option.
} | ||
else | ||
{ | ||
Assert.True(point is PENamedTypeSymbol); | ||
Assert.False(point.IsRecordStruct); | ||
Assert.False(point.GetPublicSymbol().IsRecord); | ||
Assert.Equal("struct Point", point.ToDisplayString(SymbolDisplayFormat.TestFormat.AddKindOptions(SymbolDisplayKindOptions.IncludeTypeKeyword))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IncludeTypeKeyword [](start = 142, length = 18)
Similar here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 1)
Test plan #51199