Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh features/record-structs with latest bits from main branch #52762

Merged
merged 274 commits into from
Apr 21, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
274 commits
Select commit Hold shift + click to select a range
00744f2
Update IDEDiagnosticIDConfigurationTests.cs
Youssef1313 Mar 23, 2021
fddba3c
Address feedback
Youssef1313 Mar 23, 2021
8839767
Address feedback
Youssef1313 Mar 24, 2021
5dad410
Update Xlf
Youssef1313 Mar 27, 2021
c5716b5
Fix test
Youssef1313 Mar 28, 2021
3a6b9eb
Fix SimplifyObjectCreation_CodeStyleOptionTurnedOn
Youssef1313 Apr 1, 2021
6e2a4b0
Update BasicEditorConfigGeneratorTests.vb
Youssef1313 Apr 1, 2021
c8f3f56
PredefinedCodeFixProviderNames.SimplifyObjectCreation
Youssef1313 Apr 1, 2021
47bb540
PredefinedCodeFixProviderNames.SimplifyObjectCreation
Youssef1313 Apr 1, 2021
0f1549e
Update EnforceOnBuildValues.cs
Youssef1313 Apr 1, 2021
8b7ba92
Merge branch 'main' into simplify-obj-creation-analyzer
Youssef1313 Apr 2, 2021
d17ca65
Explicitly hold onto syntax tree while doing syntactic classification…
CyrusNajmabadi Apr 6, 2021
3bfe228
REstore.
CyrusNajmabadi Apr 6, 2021
f5e6506
Add helpers
CyrusNajmabadi Apr 7, 2021
c11f1c0
Support reporting more accurate 'changed spans' when doing syntactic …
CyrusNajmabadi Apr 7, 2021
b04456c
Add tests
CyrusNajmabadi Apr 7, 2021
0c06cd0
Add to public api
CyrusNajmabadi Apr 7, 2021
dc78417
Tweaks
CyrusNajmabadi Apr 7, 2021
6611ac7
Add docs
CyrusNajmabadi Apr 7, 2021
fdb694e
Add tests
CyrusNajmabadi Apr 7, 2021
e4c630a
Add actual test of the tagger.
CyrusNajmabadi Apr 8, 2021
9ba020c
Merge branch 'main' into patch-41
Youssef1313 Apr 8, 2021
16dc18b
Public API
CyrusNajmabadi Apr 8, 2021
1eefea9
Add benchmark
CyrusNajmabadi Apr 8, 2021
72df51a
Allow service to dictate cached data
CyrusNajmabadi Apr 8, 2021
62d6267
Fix index
CyrusNajmabadi Apr 8, 2021
6a8d432
Make into timespan
CyrusNajmabadi Apr 9, 2021
1d3108d
Use helper extension
CyrusNajmabadi Apr 9, 2021
7715cee
Move timeout into diff algorithm itself
CyrusNajmabadi Apr 9, 2021
9b1223e
Fix goto types to include records
Youssef1313 Apr 9, 2021
39efab5
use value tasks
CyrusNajmabadi Apr 9, 2021
d63e198
Move nav bars to be async when items are selected.
CyrusNajmabadi Apr 9, 2021
18e8b74
In progress
CyrusNajmabadi Apr 9, 2021
aa89171
In progress
CyrusNajmabadi Apr 9, 2021
e04fa94
In progress
CyrusNajmabadi Apr 9, 2021
c4e02a5
Make async
CyrusNajmabadi Apr 9, 2021
ad0c421
Report errors
CyrusNajmabadi Apr 9, 2021
58b5e9a
docs
CyrusNajmabadi Apr 9, 2021
7813cc2
Simplify
CyrusNajmabadi Apr 9, 2021
37e7d4a
REmove lock
CyrusNajmabadi Apr 9, 2021
dd8bdaf
Switch to immutable arrays
CyrusNajmabadi Apr 9, 2021
65f6630
Update tests to be ok with async processing.
CyrusNajmabadi Apr 9, 2021
4fe5346
Update SyntaxNode.cs
CyrusNajmabadi Apr 9, 2021
6c23c35
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi Apr 9, 2021
2184758
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi Apr 9, 2021
af8d17a
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi Apr 9, 2021
fe1f291
Update src/Compilers/Core/Portable/Syntax/SyntaxNodeOrToken.cs
CyrusNajmabadi Apr 9, 2021
2fde204
Update src/Compilers/Core/Portable/Syntax/SyntaxNodeOrToken.cs
CyrusNajmabadi Apr 9, 2021
341ced0
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi Apr 10, 2021
65e2287
Fix
CyrusNajmabadi Apr 10, 2021
9b8474c
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi Apr 10, 2021
0f52f13
Fix
CyrusNajmabadi Apr 10, 2021
56a98c4
UPdate check
CyrusNajmabadi Apr 10, 2021
ae11871
Merge branch 'classificationDiff' of https://github.com/CyrusNajmabad…
CyrusNajmabadi Apr 10, 2021
67669de
Fix api
CyrusNajmabadi Apr 10, 2021
7581689
simplify
CyrusNajmabadi Apr 10, 2021
7169bc0
Wrap
CyrusNajmabadi Apr 10, 2021
22ec67a
Simplify
CyrusNajmabadi Apr 10, 2021
30f9301
Reorder
CyrusNajmabadi Apr 10, 2021
0881afe
simplify
CyrusNajmabadi Apr 10, 2021
98ed945
Remove unused parameter
CyrusNajmabadi Apr 10, 2021
ad058b0
doc
CyrusNajmabadi Apr 10, 2021
63b2961
no need to yield, we're not on the Ui thread here.
CyrusNajmabadi Apr 10, 2021
afda833
Simplify
CyrusNajmabadi Apr 10, 2021
b51524b
Revert change to support typescript
CyrusNajmabadi Apr 10, 2021
7e353ae
Use immutable arrays
CyrusNajmabadi Apr 10, 2021
81bbc3b
Use immutable arrays
CyrusNajmabadi Apr 10, 2021
be1f75f
Merge remote-tracking branch 'upstream/main' into asyncNavBar
CyrusNajmabadi Apr 10, 2021
e9315fa
nrt
CyrusNajmabadi Apr 10, 2021
9065f1d
revert
CyrusNajmabadi Apr 10, 2021
6fa3217
Implement proper interface
CyrusNajmabadi Apr 10, 2021
6711fa4
Fix tuple naming
Youssef1313 Apr 10, 2021
d72004d
Add DeclaredSymbolInfoKind.Record back
Youssef1313 Apr 10, 2021
14b6e4e
Suggest simplifying ToString with invariant provider inside Formattab…
jnm2 Apr 12, 2021
44c6923
Extract implementation details
jnm2 Apr 12, 2021
9ce6c57
Recognize other ways to specify invariant culture
jnm2 Apr 12, 2021
a3f7291
Extraction requested in review
jnm2 Apr 12, 2021
effbe1b
Refactor to a statement form per review
jnm2 Apr 12, 2021
4d828ba
It's a failure on the part of the caller if no semantic model is avai…
jnm2 Apr 12, 2021
bffbe0b
Extract helper to compare types by metadata name
jnm2 Apr 12, 2021
200390b
Centralize remaining usage of GetTypeByMetadataName
jnm2 Apr 12, 2021
42e61aa
Update src/Analyzers/Core/Analyzers/SimplifyInterpolation/Helpers.cs
CyrusNajmabadi Apr 12, 2021
34f0a15
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi Apr 12, 2021
e85d7d2
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi Apr 12, 2021
3a6a891
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi Apr 12, 2021
a1301b4
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi Apr 12, 2021
a77302b
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi Apr 13, 2021
4a363b4
Add tests
CyrusNajmabadi Apr 13, 2021
23d3541
Merge branch 'main' into extra-space-editorconfig
Youssef1313 Apr 13, 2021
243c33c
Address feedback
Youssef1313 Apr 13, 2021
a438196
Remove unused parameter
Youssef1313 Apr 13, 2021
aa29bd7
More fixes
Youssef1313 Apr 13, 2021
e0bfe26
Merge pull request #52523 from Youssef1313/goto-types
CyrusNajmabadi Apr 13, 2021
94ac917
Fix CA1012
Youssef1313 Apr 13, 2021
cfcd06a
Fix CA1012
Youssef1313 Apr 13, 2021
e551f4f
Fix CA1012
Youssef1313 Apr 13, 2021
ce227dc
Add AddUnderlyingEnumType in SymbolVisitor and tests
MaStr11 Apr 13, 2021
d43e561
Correctly supress/elevate diagnostics produced by source generators (…
chsienki Apr 13, 2021
b150a0f
Initial modeling of the symbol group
CyrusNajmabadi Apr 13, 2021
6ebeea7
Implement cascadign logic
CyrusNajmabadi Apr 13, 2021
aeb2e24
Merge pull request #50608 from Youssef1313/extra-space-editorconfig
jasonmalinowski Apr 13, 2021
d85af7c
Add sg v2 status (#52611)
chsienki Apr 13, 2021
6f2a286
Create definition item from symbol group
CyrusNajmabadi Apr 13, 2021
ae3c9fb
Working
CyrusNajmabadi Apr 13, 2021
04b0d7b
Share code
CyrusNajmabadi Apr 13, 2021
a599998
Simplify
CyrusNajmabadi Apr 13, 2021
dd2d325
Simplify
CyrusNajmabadi Apr 13, 2021
120b10d
Simplify
CyrusNajmabadi Apr 13, 2021
5aaa845
Simplify
CyrusNajmabadi Apr 13, 2021
b87e067
Simplify
CyrusNajmabadi Apr 13, 2021
efae208
Simplify
CyrusNajmabadi Apr 13, 2021
977a641
Only add if we have more than 1
CyrusNajmabadi Apr 13, 2021
f8891cf
Simplify
CyrusNajmabadi Apr 13, 2021
4c7fece
Update src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finder…
CyrusNajmabadi Apr 13, 2021
e59d792
Update src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finder…
CyrusNajmabadi Apr 13, 2021
5e5bf4f
Add docs
CyrusNajmabadi Apr 13, 2021
e120c87
Fix hydration
CyrusNajmabadi Apr 13, 2021
dc8070e
Merge branch 'findRefsGroups' of https://github.com/CyrusNajmabadi/ro…
CyrusNajmabadi Apr 13, 2021
720bad7
Simplify
CyrusNajmabadi Apr 13, 2021
a285b01
Don't create multiple mappings
CyrusNajmabadi Apr 13, 2021
a5b7794
Sort the flavors
CyrusNajmabadi Apr 13, 2021
bbcc4ad
Property equality
CyrusNajmabadi Apr 13, 2021
ed1298d
Add lsp filtering
CyrusNajmabadi Apr 14, 2021
7b751cb
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi Apr 14, 2021
935b654
Mark as nullable
CyrusNajmabadi Apr 14, 2021
86b558f
Update src/EditorFeatures/Core/Implementation/Classification/Syntacti…
CyrusNajmabadi Apr 14, 2021
00a09e2
Simplify
CyrusNajmabadi Apr 14, 2021
3f88d99
FInish comment
CyrusNajmabadi Apr 14, 2021
134e99c
Merge branch 'classificationDiff' of https://github.com/CyrusNajmabad…
CyrusNajmabadi Apr 14, 2021
9d3baec
Simplify code
CyrusNajmabadi Apr 14, 2021
8de0e62
Simplify
CyrusNajmabadi Apr 14, 2021
57eb3f4
Simplify
CyrusNajmabadi Apr 14, 2021
8d18526
Fix api
CyrusNajmabadi Apr 14, 2021
2680ed6
Remove item
CyrusNajmabadi Apr 14, 2021
f1110cb
Make method obsolete
CyrusNajmabadi Apr 14, 2021
76d2397
Make obsolete
CyrusNajmabadi Apr 14, 2021
7e56c2b
NRT
CyrusNajmabadi Apr 14, 2021
1cb33bb
Add assert
CyrusNajmabadi Apr 14, 2021
f3666ca
Update src/EditorFeatures/Core/Implementation/NavigationBar/Navigatio…
CyrusNajmabadi Apr 14, 2021
e520166
Add async token
CyrusNajmabadi Apr 14, 2021
1fb7242
Escape special characters in section name of editor config (#52515)
captainsafia Apr 14, 2021
8ce6cf4
Merge pull request #52472 from CyrusNajmabadi/classificationDiff
CyrusNajmabadi Apr 14, 2021
1466e4d
Merge remote-tracking branch 'upstream/main' into findRefsGroups
CyrusNajmabadi Apr 14, 2021
3ca0325
Remove extra display parts
CyrusNajmabadi Apr 14, 2021
d11c0b7
revert'
CyrusNajmabadi Apr 14, 2021
81bee93
Merge remote-tracking branch 'upstream/main' into asyncNavBar
CyrusNajmabadi Apr 14, 2021
51ac5f7
Warning
CyrusNajmabadi Apr 14, 2021
fe85bc4
Simplify
CyrusNajmabadi Apr 14, 2021
dee03b4
Temp array
CyrusNajmabadi Apr 14, 2021
305a77f
Simplify
CyrusNajmabadi Apr 14, 2021
5794d4d
Simplify
CyrusNajmabadi Apr 14, 2021
f445d59
Simplify
CyrusNajmabadi Apr 14, 2021
f8a3a0e
Simplify
CyrusNajmabadi Apr 14, 2021
3e56c17
Thread safety
CyrusNajmabadi Apr 14, 2021
67e3d9e
Thread safety
CyrusNajmabadi Apr 14, 2021
59b3853
Fix
CyrusNajmabadi Apr 14, 2021
0676fe3
Merge pull request #52618 from CyrusNajmabadi/findRefsGroups
CyrusNajmabadi Apr 14, 2021
e15103c
Revert changes in SymbolDisplayVisitor
MaStr11 Apr 14, 2021
91ac349
Add test in SemanticQuickInfoSourceTests
MaStr11 Apr 14, 2021
4c2660c
Remove tests in SymbolDisplayTests
MaStr11 Apr 14, 2021
e6d44d7
Add WorkItem to test
MaStr11 Apr 14, 2021
1958898
Add underlying type handling to AbstractSymbolDisplayService.Abstract…
MaStr11 Apr 14, 2021
f3424aa
Add C# tests for different type positions.
MaStr11 Apr 14, 2021
2612d58
Add more C# tests.
MaStr11 Apr 14, 2021
60be588
Add text classification test
MaStr11 Apr 14, 2021
4c26426
Add support for VB.
MaStr11 Apr 14, 2021
b77d3bb
Improve Server Logging (#52572)
jaredpar Apr 14, 2021
4875763
Enable test and change to use correct method
ryzngard Apr 14, 2021
a1dd1f9
Multi-target Microsoft.CodeAnalysis.Workspaces.Desktop
jasonmalinowski Apr 14, 2021
08faabb
Add telemetry for when the infobar is shown from using IErrorReportin…
ryzngard Apr 14, 2021
5e1f093
Merge pull request #51721 from Youssef1313/fix-21948
CyrusNajmabadi Apr 14, 2021
e185b26
Merge pull request #52603 from MaStr11/SymbolDisplayShowNonDefaultUnd…
CyrusNajmabadi Apr 14, 2021
1ee2cb9
Fix doc comment.
CyrusNajmabadi Apr 14, 2021
1a4a2dd
Merge pull request #52627 from ryzngard/issues/51818_test_enable
ryzngard Apr 14, 2021
8eb9b59
Update src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
CyrusNajmabadi Apr 14, 2021
ac5b4cf
Update src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
CyrusNajmabadi Apr 14, 2021
c4e2bf9
Do not cancel classification change notifications
CyrusNajmabadi Apr 14, 2021
0f3e319
Remove superfluous wait
CyrusNajmabadi Apr 14, 2021
7b494a1
Merge pull request #52077 from Youssef1313/simplify-obj-creation-anal…
CyrusNajmabadi Apr 14, 2021
78d5a9f
Merge pull request #52637 from CyrusNajmabadi/fixComment
CyrusNajmabadi Apr 14, 2021
81a56ec
EnC - Support for records (#51926)
davidwengier Apr 14, 2021
fb8d3ae
Merge pull request #52631 from jasonmalinowski/multi-target-legacy-de…
jasonmalinowski Apr 15, 2021
767de77
Make image catalog private
dibarbet Apr 15, 2021
39c85f3
Merge pull request #52638 from CyrusNajmabadi/removeCancellation
CyrusNajmabadi Apr 15, 2021
c3b323b
Merge pull request #52645 from dibarbet/imagecatalog_private
dibarbet Apr 15, 2021
7564723
Merge pull request #52633 from ryzngard/issues/52500_infobar_error_te…
ryzngard Apr 15, 2021
e2afdb6
Remove unnecessary check
CyrusNajmabadi Apr 15, 2021
8f27533
report errors
CyrusNajmabadi Apr 15, 2021
9a9bd4b
Change obsolete message
CyrusNajmabadi Apr 15, 2021
00186ed
get rid of async
CyrusNajmabadi Apr 15, 2021
0a883bb
Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/E…
Youssef1313 Apr 15, 2021
ac65a9d
Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/E…
Youssef1313 Apr 15, 2021
0255d3e
Extract helper
Youssef1313 Apr 15, 2021
81a281d
Add CT
CyrusNajmabadi Apr 15, 2021
9f29a9f
Merge pull request #52530 from CyrusNajmabadi/asyncNavBar
CyrusNajmabadi Apr 15, 2021
90ff6db
Fix FAR for less than operator and add tests for all operators
Youssef1313 Apr 15, 2021
a23bc8d
Fix failing test
Youssef1313 Apr 15, 2021
e0ebe28
Implement ManagedHotReloadLanguageService (#52640)
tmat Apr 15, 2021
e7d9cc1
Update CSharpHelpContextService.cs
Youssef1313 Apr 15, 2021
4cd2797
Merge branch 'main' into remove_dead_loggers
dibarbet Apr 15, 2021
639c8f7
Merge pull request #51831 from Youssef1313/patch-41
jmarolf Apr 15, 2021
65dbb64
Merge pull request #52001 from dibarbet/remove_dead_loggers
dibarbet Apr 15, 2021
04e1919
Fix syntactic range computation.
CyrusNajmabadi Apr 16, 2021
c8afc01
Add tests
CyrusNajmabadi Apr 16, 2021
91da397
REvert
CyrusNajmabadi Apr 16, 2021
b5d5a2c
Update status of record features (#52575)
jcouv Apr 16, 2021
243bd42
Merge pull request #52672 from CyrusNajmabadi/outOfBounds
CyrusNajmabadi Apr 16, 2021
bed18dd
Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContext…
Youssef1313 Apr 16, 2021
79eb35b
Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContext…
Youssef1313 Apr 16, 2021
4b27a2d
Merge pull request #52656 from Youssef1313/patch-17
CyrusNajmabadi Apr 16, 2021
883ec07
Update DocumentationMode docs (#52675)
Youssef1313 Apr 16, 2021
c31d8af
[main] Update dependencies from dotnet/arcade (#52683)
dotnet-maestro[bot] Apr 16, 2021
78cbf23
Fix build of our .NET 2.0-targeting projects
jasonmalinowski Apr 16, 2021
ec92c24
Simplify code style option check
Youssef1313 Apr 17, 2021
3253f40
Merge pull request #52693 from Youssef1313/patch-17
CyrusNajmabadi Apr 17, 2021
e9ad1db
Fix formatting
Youssef1313 Apr 17, 2021
86637d4
Merge pull request #52541 from Youssef1313/patch-8
CyrusNajmabadi Apr 17, 2021
9c67fb1
Merge pull request #51760 from Youssef1313/record-attribute-target-co…
CyrusNajmabadi Apr 17, 2021
19ca04b
Remove virtual functionality that was never overridden
CyrusNajmabadi Apr 17, 2021
4e2de2c
Fix build caused by independent merges that conflicted
CyrusNajmabadi Apr 17, 2021
43eca1a
Merge branch 'fixBuild' into taggerSimplification
CyrusNajmabadi Apr 17, 2021
58eed4e
Remove virtual functionality that was never overridden
CyrusNajmabadi Apr 17, 2021
1eca3c6
Simplify
CyrusNajmabadi Apr 17, 2021
24d034e
Remove tagger functionality related to pausing/resumign tagging.
CyrusNajmabadi Apr 17, 2021
11d6292
Merge pull request #52704 from CyrusNajmabadi/fixBuild
CyrusNajmabadi Apr 18, 2021
3d120cf
Merge remote-tracking branch 'upstream/main' into taggerSimplification
CyrusNajmabadi Apr 18, 2021
0d915c7
Merge remote-tracking branch 'upstream/main' into taggerSimplification2
CyrusNajmabadi Apr 18, 2021
3238600
Remove
CyrusNajmabadi Apr 18, 2021
81c70ba
Merge pull request #52564 from jnm2/culture_interpolation
CyrusNajmabadi Apr 18, 2021
543371b
Fix merge conflicts
jnm2 Apr 18, 2021
fb11e25
Merge pull request #52705 from CyrusNajmabadi/taggerSimplification
CyrusNajmabadi Apr 19, 2021
24f1930
Merge pull request #52706 from CyrusNajmabadi/taggerSimplification2
CyrusNajmabadi Apr 19, 2021
4b1cd21
Make ExitingTraceListener log visible (#52719)
jaredpar Apr 19, 2021
500735c
Ensure that we register to analyzer generated code for MakeFieldReadO…
mavasani Apr 19, 2021
de17f29
Address feedback
mavasani Apr 19, 2021
3fd808a
Merge pull request #52726 from mavasani/FixGeneratedCodeIssue
mavasani Apr 19, 2021
13a4a8f
[main] Update dependencies from dotnet/roslyn (#52570)
dotnet-maestro[bot] Apr 19, 2021
16121b1
Cleanup
Youssef1313 Apr 19, 2021
6f0ab27
Fix
Youssef1313 Apr 19, 2021
d25ea98
Merge pull request #52686 from jasonmalinowski/change-net20-framework…
jasonmalinowski Apr 19, 2021
9898e1c
Make method private
CyrusNajmabadi Apr 19, 2021
04d7570
Merge pull request #52733 from Youssef1313/doc-comment-cleanup
mavasani Apr 19, 2021
d7236c6
Use compile-time solution for solution crawler and EnC (#52537)
tmat Apr 19, 2021
497a472
Merge pull request #49717 from jnm2/simplify_interpolation_vb_alignment
CyrusNajmabadi Apr 19, 2021
561cb96
Merge pull request #52742 from CyrusNajmabadi/makePrivate
CyrusNajmabadi Apr 19, 2021
3abea95
Error for using positional member that is hidden (#52660)
jcouv Apr 19, 2021
9a64656
Merge remote-tracking branch 'dotnet/main' into HEAD
jcouv Apr 19, 2021
46ec3ee
Resolve conflicts
jcouv Apr 19, 2021
1ecbcdd
Fixup a couple more tests
jcouv Apr 20, 2021
2a5f985
Adjust EnC test on records
jcouv Apr 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3542,11 +3542,8 @@ private void AddSynthesizedRecordMembersIfNecessary(MembersAndInitializersBuilde
addToStringMethod(printMembers);

memberSignatures.Free();
<<<<<<< HEAD
fieldsByName.Free();
=======
memberNames.Free();
>>>>>>> dotnet/main

// We put synthesized record members first so that errors about conflicts show up on user-defined members rather than all
// going to the record declaration
Expand Down Expand Up @@ -3815,7 +3812,10 @@ ImmutableArray<Symbol> addProperties(ImmutableArray<ParameterSymbol> recordParam
&& field.TypeWithAnnotations.Equals(param.TypeWithAnnotations, TypeCompareKind.AllIgnoreOptions))
{
Binder.CheckFeatureAvailability(syntax, MessageID.IDS_FeaturePositionalFieldsInRecords, diagnostics);
existingOrAddedMembers.Add(field);
if (!isInherited || checkMemberNotHidden(field, param))
{
existingOrAddedMembers.Add(field);
}
}
else if (existingMember is PropertySymbol { IsStatic: false, GetMethod: { } } prop
&& prop.TypeWithAnnotations.Equals(param.TypeWithAnnotations, TypeCompareKind.AllIgnoreOptions))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10667,13 +10667,15 @@ protected virtual bool PrintMembers(System.Text.StringBuilder builder)
Row(21, TableIndex.TypeRef, EditAndContinueOperation.Default),
Row(4, TableIndex.TypeSpec, EditAndContinueOperation.Default),
Row(3, TableIndex.StandAloneSig, EditAndContinueOperation.Default),
Row(10, TableIndex.MethodDef, EditAndContinueOperation.Default)); // R.PrintMembers
Row(10, TableIndex.MethodDef, EditAndContinueOperation.Default), // R.PrintMembers
Row(24, TableIndex.CustomAttribute, EditAndContinueOperation.Default));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this attribute?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking at what we emit, it is the NullableContextAttribute. This matches my expectation because the record-structs branch fixed nullability annotations on the synthesized PrintMembers.

But looking at the metadata reader (reader1) something looked off (index out of bounds). Talked to @davidwengier, but he's not sure what to expect (this may be the result of EnC doing row mappings...). Will check with @tmat

            EditAndContinueLogEntry temp = reader1.GetEditAndContinueLogEntries().Last();
            CustomAttribute temp2 = reader1.GetCustomAttribute((CustomAttributeHandle)temp.Handle);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Tomas that trying to get the attribute with reader1.GetCustomAttribute(...) is expected to fail.
He suggested that I add #nullable enable to the test to revert to previous behavior. Currently attribute changes are not considered supported by EnC.
Filed #52786


CheckEncMap(reader1,
Handle(19, TableIndex.TypeRef),
Handle(20, TableIndex.TypeRef),
Handle(21, TableIndex.TypeRef),
Handle(10, TableIndex.MethodDef),
Handle(24, TableIndex.CustomAttribute),
Handle(3, TableIndex.StandAloneSig),
Handle(4, TableIndex.TypeSpec),
Handle(2, TableIndex.AssemblyRef));
Expand Down
Loading