-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh features/record-structs
with latest bits from main
branch
#52762
Merged
Merged
Changes from 1 commit
Commits
Show all changes
274 commits
Select commit
Hold shift + click to select a range
00744f2
Update IDEDiagnosticIDConfigurationTests.cs
Youssef1313 fddba3c
Address feedback
Youssef1313 8839767
Address feedback
Youssef1313 5dad410
Update Xlf
Youssef1313 c5716b5
Fix test
Youssef1313 3a6b9eb
Fix SimplifyObjectCreation_CodeStyleOptionTurnedOn
Youssef1313 6e2a4b0
Update BasicEditorConfigGeneratorTests.vb
Youssef1313 c8f3f56
PredefinedCodeFixProviderNames.SimplifyObjectCreation
Youssef1313 47bb540
PredefinedCodeFixProviderNames.SimplifyObjectCreation
Youssef1313 0f1549e
Update EnforceOnBuildValues.cs
Youssef1313 8b7ba92
Merge branch 'main' into simplify-obj-creation-analyzer
Youssef1313 d17ca65
Explicitly hold onto syntax tree while doing syntactic classification…
CyrusNajmabadi 3bfe228
REstore.
CyrusNajmabadi f5e6506
Add helpers
CyrusNajmabadi c11f1c0
Support reporting more accurate 'changed spans' when doing syntactic …
CyrusNajmabadi b04456c
Add tests
CyrusNajmabadi 0c06cd0
Add to public api
CyrusNajmabadi dc78417
Tweaks
CyrusNajmabadi 6611ac7
Add docs
CyrusNajmabadi fdb694e
Add tests
CyrusNajmabadi e4c630a
Add actual test of the tagger.
CyrusNajmabadi 9ba020c
Merge branch 'main' into patch-41
Youssef1313 16dc18b
Public API
CyrusNajmabadi 1eefea9
Add benchmark
CyrusNajmabadi 72df51a
Allow service to dictate cached data
CyrusNajmabadi 62d6267
Fix index
CyrusNajmabadi 6a8d432
Make into timespan
CyrusNajmabadi 1d3108d
Use helper extension
CyrusNajmabadi 7715cee
Move timeout into diff algorithm itself
CyrusNajmabadi 9b1223e
Fix goto types to include records
Youssef1313 39efab5
use value tasks
CyrusNajmabadi d63e198
Move nav bars to be async when items are selected.
CyrusNajmabadi 18e8b74
In progress
CyrusNajmabadi aa89171
In progress
CyrusNajmabadi e04fa94
In progress
CyrusNajmabadi c4e02a5
Make async
CyrusNajmabadi ad0c421
Report errors
CyrusNajmabadi 58b5e9a
docs
CyrusNajmabadi 7813cc2
Simplify
CyrusNajmabadi 37e7d4a
REmove lock
CyrusNajmabadi dd8bdaf
Switch to immutable arrays
CyrusNajmabadi 65f6630
Update tests to be ok with async processing.
CyrusNajmabadi 4fe5346
Update SyntaxNode.cs
CyrusNajmabadi 6c23c35
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi 2184758
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi af8d17a
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi fe1f291
Update src/Compilers/Core/Portable/Syntax/SyntaxNodeOrToken.cs
CyrusNajmabadi 2fde204
Update src/Compilers/Core/Portable/Syntax/SyntaxNodeOrToken.cs
CyrusNajmabadi 341ced0
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi 65e2287
Fix
CyrusNajmabadi 9b8474c
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi 0f52f13
Fix
CyrusNajmabadi 56a98c4
UPdate check
CyrusNajmabadi ae11871
Merge branch 'classificationDiff' of https://github.com/CyrusNajmabad…
CyrusNajmabadi 67669de
Fix api
CyrusNajmabadi 7581689
simplify
CyrusNajmabadi 7169bc0
Wrap
CyrusNajmabadi 22ec67a
Simplify
CyrusNajmabadi 30f9301
Reorder
CyrusNajmabadi 0881afe
simplify
CyrusNajmabadi 98ed945
Remove unused parameter
CyrusNajmabadi ad058b0
doc
CyrusNajmabadi 63b2961
no need to yield, we're not on the Ui thread here.
CyrusNajmabadi afda833
Simplify
CyrusNajmabadi b51524b
Revert change to support typescript
CyrusNajmabadi 7e353ae
Use immutable arrays
CyrusNajmabadi 81bbc3b
Use immutable arrays
CyrusNajmabadi be1f75f
Merge remote-tracking branch 'upstream/main' into asyncNavBar
CyrusNajmabadi e9315fa
nrt
CyrusNajmabadi 9065f1d
revert
CyrusNajmabadi 6fa3217
Implement proper interface
CyrusNajmabadi 6711fa4
Fix tuple naming
Youssef1313 d72004d
Add DeclaredSymbolInfoKind.Record back
Youssef1313 14b6e4e
Suggest simplifying ToString with invariant provider inside Formattab…
jnm2 44c6923
Extract implementation details
jnm2 9ce6c57
Recognize other ways to specify invariant culture
jnm2 a3f7291
Extraction requested in review
jnm2 effbe1b
Refactor to a statement form per review
jnm2 4d828ba
It's a failure on the part of the caller if no semantic model is avai…
jnm2 bffbe0b
Extract helper to compare types by metadata name
jnm2 200390b
Centralize remaining usage of GetTypeByMetadataName
jnm2 42e61aa
Update src/Analyzers/Core/Analyzers/SimplifyInterpolation/Helpers.cs
CyrusNajmabadi 34f0a15
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi e85d7d2
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi 3a6a891
Update src/Compilers/Core/Portable/Syntax/SyntaxToken.cs
CyrusNajmabadi a1301b4
Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs
CyrusNajmabadi a77302b
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi 4a363b4
Add tests
CyrusNajmabadi 23d3541
Merge branch 'main' into extra-space-editorconfig
Youssef1313 243c33c
Address feedback
Youssef1313 a438196
Remove unused parameter
Youssef1313 aa29bd7
More fixes
Youssef1313 e0bfe26
Merge pull request #52523 from Youssef1313/goto-types
CyrusNajmabadi 94ac917
Fix CA1012
Youssef1313 cfcd06a
Fix CA1012
Youssef1313 e551f4f
Fix CA1012
Youssef1313 ce227dc
Add AddUnderlyingEnumType in SymbolVisitor and tests
MaStr11 d43e561
Correctly supress/elevate diagnostics produced by source generators (…
chsienki b150a0f
Initial modeling of the symbol group
CyrusNajmabadi 6ebeea7
Implement cascadign logic
CyrusNajmabadi aeb2e24
Merge pull request #50608 from Youssef1313/extra-space-editorconfig
jasonmalinowski d85af7c
Add sg v2 status (#52611)
chsienki 6f2a286
Create definition item from symbol group
CyrusNajmabadi ae3c9fb
Working
CyrusNajmabadi 04b0d7b
Share code
CyrusNajmabadi a599998
Simplify
CyrusNajmabadi dd2d325
Simplify
CyrusNajmabadi 120b10d
Simplify
CyrusNajmabadi 5aaa845
Simplify
CyrusNajmabadi b87e067
Simplify
CyrusNajmabadi efae208
Simplify
CyrusNajmabadi 977a641
Only add if we have more than 1
CyrusNajmabadi f8891cf
Simplify
CyrusNajmabadi 4c7fece
Update src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finder…
CyrusNajmabadi e59d792
Update src/Workspaces/Core/Portable/FindSymbols/FindReferences/Finder…
CyrusNajmabadi 5e5bf4f
Add docs
CyrusNajmabadi e120c87
Fix hydration
CyrusNajmabadi dc8070e
Merge branch 'findRefsGroups' of https://github.com/CyrusNajmabadi/ro…
CyrusNajmabadi 720bad7
Simplify
CyrusNajmabadi a285b01
Don't create multiple mappings
CyrusNajmabadi a5b7794
Sort the flavors
CyrusNajmabadi bbcc4ad
Property equality
CyrusNajmabadi ed1298d
Add lsp filtering
CyrusNajmabadi 7b751cb
Merge remote-tracking branch 'upstream/main' into classificationDiff
CyrusNajmabadi 935b654
Mark as nullable
CyrusNajmabadi 86b558f
Update src/EditorFeatures/Core/Implementation/Classification/Syntacti…
CyrusNajmabadi 00a09e2
Simplify
CyrusNajmabadi 3f88d99
FInish comment
CyrusNajmabadi 134e99c
Merge branch 'classificationDiff' of https://github.com/CyrusNajmabad…
CyrusNajmabadi 9d3baec
Simplify code
CyrusNajmabadi 8de0e62
Simplify
CyrusNajmabadi 57eb3f4
Simplify
CyrusNajmabadi 8d18526
Fix api
CyrusNajmabadi 2680ed6
Remove item
CyrusNajmabadi f1110cb
Make method obsolete
CyrusNajmabadi 76d2397
Make obsolete
CyrusNajmabadi 7e56c2b
NRT
CyrusNajmabadi 1cb33bb
Add assert
CyrusNajmabadi f3666ca
Update src/EditorFeatures/Core/Implementation/NavigationBar/Navigatio…
CyrusNajmabadi e520166
Add async token
CyrusNajmabadi 1fb7242
Escape special characters in section name of editor config (#52515)
captainsafia 8ce6cf4
Merge pull request #52472 from CyrusNajmabadi/classificationDiff
CyrusNajmabadi 1466e4d
Merge remote-tracking branch 'upstream/main' into findRefsGroups
CyrusNajmabadi 3ca0325
Remove extra display parts
CyrusNajmabadi d11c0b7
revert'
CyrusNajmabadi 81bee93
Merge remote-tracking branch 'upstream/main' into asyncNavBar
CyrusNajmabadi 51ac5f7
Warning
CyrusNajmabadi fe85bc4
Simplify
CyrusNajmabadi dee03b4
Temp array
CyrusNajmabadi 305a77f
Simplify
CyrusNajmabadi 5794d4d
Simplify
CyrusNajmabadi f445d59
Simplify
CyrusNajmabadi f8a3a0e
Simplify
CyrusNajmabadi 3e56c17
Thread safety
CyrusNajmabadi 67e3d9e
Thread safety
CyrusNajmabadi 59b3853
Fix
CyrusNajmabadi 0676fe3
Merge pull request #52618 from CyrusNajmabadi/findRefsGroups
CyrusNajmabadi e15103c
Revert changes in SymbolDisplayVisitor
MaStr11 91ac349
Add test in SemanticQuickInfoSourceTests
MaStr11 4c2660c
Remove tests in SymbolDisplayTests
MaStr11 e6d44d7
Add WorkItem to test
MaStr11 1958898
Add underlying type handling to AbstractSymbolDisplayService.Abstract…
MaStr11 f3424aa
Add C# tests for different type positions.
MaStr11 2612d58
Add more C# tests.
MaStr11 60be588
Add text classification test
MaStr11 4c26426
Add support for VB.
MaStr11 b77d3bb
Improve Server Logging (#52572)
jaredpar 4875763
Enable test and change to use correct method
ryzngard a1dd1f9
Multi-target Microsoft.CodeAnalysis.Workspaces.Desktop
jasonmalinowski 08faabb
Add telemetry for when the infobar is shown from using IErrorReportin…
ryzngard 5e1f093
Merge pull request #51721 from Youssef1313/fix-21948
CyrusNajmabadi e185b26
Merge pull request #52603 from MaStr11/SymbolDisplayShowNonDefaultUnd…
CyrusNajmabadi 1ee2cb9
Fix doc comment.
CyrusNajmabadi 1a4a2dd
Merge pull request #52627 from ryzngard/issues/51818_test_enable
ryzngard 8eb9b59
Update src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
CyrusNajmabadi ac5b4cf
Update src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
CyrusNajmabadi c4e2bf9
Do not cancel classification change notifications
CyrusNajmabadi 0f3e319
Remove superfluous wait
CyrusNajmabadi 7b494a1
Merge pull request #52077 from Youssef1313/simplify-obj-creation-anal…
CyrusNajmabadi 78d5a9f
Merge pull request #52637 from CyrusNajmabadi/fixComment
CyrusNajmabadi 81a56ec
EnC - Support for records (#51926)
davidwengier fb8d3ae
Merge pull request #52631 from jasonmalinowski/multi-target-legacy-de…
jasonmalinowski 767de77
Make image catalog private
dibarbet 39c85f3
Merge pull request #52638 from CyrusNajmabadi/removeCancellation
CyrusNajmabadi c3b323b
Merge pull request #52645 from dibarbet/imagecatalog_private
dibarbet 7564723
Merge pull request #52633 from ryzngard/issues/52500_infobar_error_te…
ryzngard e2afdb6
Remove unnecessary check
CyrusNajmabadi 8f27533
report errors
CyrusNajmabadi 9a9bd4b
Change obsolete message
CyrusNajmabadi 00186ed
get rid of async
CyrusNajmabadi 0a883bb
Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/E…
Youssef1313 ac65a9d
Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/E…
Youssef1313 0255d3e
Extract helper
Youssef1313 81a281d
Add CT
CyrusNajmabadi 9f29a9f
Merge pull request #52530 from CyrusNajmabadi/asyncNavBar
CyrusNajmabadi 90ff6db
Fix FAR for less than operator and add tests for all operators
Youssef1313 a23bc8d
Fix failing test
Youssef1313 e0ebe28
Implement ManagedHotReloadLanguageService (#52640)
tmat e7d9cc1
Update CSharpHelpContextService.cs
Youssef1313 4cd2797
Merge branch 'main' into remove_dead_loggers
dibarbet 639c8f7
Merge pull request #51831 from Youssef1313/patch-41
jmarolf 65dbb64
Merge pull request #52001 from dibarbet/remove_dead_loggers
dibarbet 04e1919
Fix syntactic range computation.
CyrusNajmabadi c8afc01
Add tests
CyrusNajmabadi 91da397
REvert
CyrusNajmabadi b5d5a2c
Update status of record features (#52575)
jcouv 243bd42
Merge pull request #52672 from CyrusNajmabadi/outOfBounds
CyrusNajmabadi bed18dd
Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContext…
Youssef1313 79eb35b
Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContext…
Youssef1313 4b27a2d
Merge pull request #52656 from Youssef1313/patch-17
CyrusNajmabadi 883ec07
Update DocumentationMode docs (#52675)
Youssef1313 c31d8af
[main] Update dependencies from dotnet/arcade (#52683)
dotnet-maestro[bot] 78cbf23
Fix build of our .NET 2.0-targeting projects
jasonmalinowski ec92c24
Simplify code style option check
Youssef1313 3253f40
Merge pull request #52693 from Youssef1313/patch-17
CyrusNajmabadi e9ad1db
Fix formatting
Youssef1313 86637d4
Merge pull request #52541 from Youssef1313/patch-8
CyrusNajmabadi 9c67fb1
Merge pull request #51760 from Youssef1313/record-attribute-target-co…
CyrusNajmabadi 19ca04b
Remove virtual functionality that was never overridden
CyrusNajmabadi 4e2de2c
Fix build caused by independent merges that conflicted
CyrusNajmabadi 43eca1a
Merge branch 'fixBuild' into taggerSimplification
CyrusNajmabadi 58eed4e
Remove virtual functionality that was never overridden
CyrusNajmabadi 1eca3c6
Simplify
CyrusNajmabadi 24d034e
Remove tagger functionality related to pausing/resumign tagging.
CyrusNajmabadi 11d6292
Merge pull request #52704 from CyrusNajmabadi/fixBuild
CyrusNajmabadi 3d120cf
Merge remote-tracking branch 'upstream/main' into taggerSimplification
CyrusNajmabadi 0d915c7
Merge remote-tracking branch 'upstream/main' into taggerSimplification2
CyrusNajmabadi 3238600
Remove
CyrusNajmabadi 81c70ba
Merge pull request #52564 from jnm2/culture_interpolation
CyrusNajmabadi 543371b
Fix merge conflicts
jnm2 fb11e25
Merge pull request #52705 from CyrusNajmabadi/taggerSimplification
CyrusNajmabadi 24f1930
Merge pull request #52706 from CyrusNajmabadi/taggerSimplification2
CyrusNajmabadi 4b1cd21
Make ExitingTraceListener log visible (#52719)
jaredpar 500735c
Ensure that we register to analyzer generated code for MakeFieldReadO…
mavasani de17f29
Address feedback
mavasani 3fd808a
Merge pull request #52726 from mavasani/FixGeneratedCodeIssue
mavasani 13a4a8f
[main] Update dependencies from dotnet/roslyn (#52570)
dotnet-maestro[bot] 16121b1
Cleanup
Youssef1313 6f0ab27
Fix
Youssef1313 d25ea98
Merge pull request #52686 from jasonmalinowski/change-net20-framework…
jasonmalinowski 9898e1c
Make method private
CyrusNajmabadi 04d7570
Merge pull request #52733 from Youssef1313/doc-comment-cleanup
mavasani d7236c6
Use compile-time solution for solution crawler and EnC (#52537)
tmat 497a472
Merge pull request #49717 from jnm2/simplify_interpolation_vb_alignment
CyrusNajmabadi 561cb96
Merge pull request #52742 from CyrusNajmabadi/makePrivate
CyrusNajmabadi 3abea95
Error for using positional member that is hidden (#52660)
jcouv 9a64656
Merge remote-tracking branch 'dotnet/main' into HEAD
jcouv 46ec3ee
Resolve conflicts
jcouv 1ecbcdd
Fixup a couple more tests
jcouv 2a5f985
Adjust EnC test on records
jcouv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By looking at what we emit, it is the NullableContextAttribute. This matches my expectation because the record-structs branch fixed nullability annotations on the synthesized PrintMembers.
But looking at the metadata reader (
reader1
) something looked off (index out of bounds). Talked to @davidwengier, but he's not sure what to expect (this may be the result of EnC doing row mappings...). Will check with @tmatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with Tomas that trying to get the attribute with
reader1.GetCustomAttribute(...)
is expected to fail.He suggested that I add
#nullable enable
to the test to revert to previous behavior. Currently attribute changes are not considered supported by EnC.Filed #52786