Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev16.10 to main #53033

Merged
merged 30 commits into from
Apr 29, 2021
Merged

Merge release/dev16.10 to main #53033

merged 30 commits into from
Apr 29, 2021

Commits on Apr 26, 2021

  1. Configuration menu
    Copy the full SHA
    2de59fd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    363d5ac View commit details
    Browse the repository at this point in the history
  2. Cleanup

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    0e1253d View commit details
    Browse the repository at this point in the history
  3. Test hook

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    e435f17 View commit details
    Browse the repository at this point in the history
  4. Simplify code.

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    b3506f7 View commit details
    Browse the repository at this point in the history
  5. Simplify queuing

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    31c94cf View commit details
    Browse the repository at this point in the history
  6. reoder'

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    2db89d0 View commit details
    Browse the repository at this point in the history
  7. Simplify queuing

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    56fd68c View commit details
    Browse the repository at this point in the history
  8. use helper'

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    057a4a1 View commit details
    Browse the repository at this point in the history
  9. ensure ordering

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    896c501 View commit details
    Browse the repository at this point in the history
  10. Extract'

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    1181c11 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ec0a12e View commit details
    Browse the repository at this point in the history
  12. Handle disposal

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    158e7ff View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0b4a2c7 View commit details
    Browse the repository at this point in the history
  14. Simplify

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    185187c View commit details
    Browse the repository at this point in the history
  15. Simplify

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    1ed5dc6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2c48c8e View commit details
    Browse the repository at this point in the history
  17. NRT

    CyrusNajmabadi committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    35555e5 View commit details
    Browse the repository at this point in the history
  18. Merge pull request #52946 from CyrusNajmabadi/restartTagging

    Cancel all current work with highlight refs when changes come in
    CyrusNajmabadi authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    617e59c View commit details
    Browse the repository at this point in the history
  19. Optimize the case when we have a generator not producing output

    In 63a1ad6 we made some performance
    optimizations where we would try to reuse compilations better. The core
    idea was if a change to a file happens, we have to update the
    compilation that doesn't contain source generated files so we can
    re-run generators; if the generated output was the same then we should
    also do the same updates to the compilation that _has_ source generators
    so we can better use compiler caches.
    
    The one case that wasn't handled well was if the compilation with
    and without generated output was actually the same: if a generator was
    added that isn't producing documents, then those compilations can
    be the same instance, but we were applying the transformations
    twice as if they were different. This fired an assert elsewhere in
    the CompilationTracker that when we're storing compilations away at
    the very end we shouldn't have two separate but semantically identical
    compilations if there are no actual generated files anywhere.
    
    The fix taken here is to adjust our logic where we update compilations
    for changes to regular files: there we were updating both compilations
    at once. If the compilations are identical, we just null out the
    "withGenerators" since we won't need to update that as well. That way
    we're only updating one copy, which will be the one passed to generators
    again. And if no generated output is still produced, that'll be the
    single compilation again stored in the FinalState.
    jasonmalinowski committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    d3801b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Move to Ubuntu 18.04 queue

    JoeRobich authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    34b64e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Configuration menu
    Copy the full SHA
    845c245 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #52979 from jasonmalinowski/fix-generator-assert

    Optimize the case when we have a generator not producing output
    jasonmalinowski authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    caa91bd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #52995 from dotnet/dev/jorobich/move-ubuntu-queue

    Move to Ubuntu 18.04 queue
    JoeRobich authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    2ec1c6c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    776d0c9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f015548 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #52934 from jmarolf/bugfix/more-resilient-editor-f…

    …actory-implementation
    
    Do not show UI if no managed projects are loaded
    jmarolf authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    92f460a View commit details
    Browse the repository at this point in the history
  7. Merge pull request #53008 from JoeRobich/make-customtags-internal

    Make CodeAction.CustomTags internal
    JoeRobich authored Apr 29, 2021
    Configuration menu
    Copy the full SHA
    e01744e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    327698b View commit details
    Browse the repository at this point in the history
  9. Implement the right interface

    tmat committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    de369e7 View commit details
    Browse the repository at this point in the history