Add records support to XmlDocCommentCompletion and ChangeSignature

src/Features/CSharp/Portable/ChangeSignature/CSharpChangeSignatureService.cs

@@ -44,7 +44,7 @@ internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureServ
             SyntaxKind.SimpleLambdaExpression,
             SyntaxKind.ParenthesizedLambdaExpression,
             SyntaxKind.LocalFunctionStatement,
-            // TODO: Record structs
+            SyntaxKind.RecordStructDeclaration,
             SyntaxKind.RecordDeclaration);
 
         private static readonly ImmutableArray<SyntaxKind> _declarationAndInvocableKinds =
@@ -89,7 +89,7 @@ internal sealed class CSharpChangeSignatureService : AbstractChangeSignatureServ
             SyntaxKind.AnonymousMethodExpression,
             SyntaxKind.ParenthesizedLambdaExpression,
             SyntaxKind.SimpleLambdaExpression,
-            // TODO: record structs
+            SyntaxKind.RecordStructDeclaration,
             SyntaxKind.RecordDeclaration);
 
         [ImportingConstructor]
@@ -272,11 +272,11 @@ public override async Task<SyntaxNode> ChangeSignatureAsync(
             var updatedNode = potentiallyUpdatedNode as CSharpSyntaxNode;
 
             // Update <param> tags.
-            // TODO: Record structs
             if (updatedNode.IsKind(SyntaxKind.MethodDeclaration) ||
                 updatedNode.IsKind(SyntaxKind.ConstructorDeclaration) ||
                 updatedNode.IsKind(SyntaxKind.IndexerDeclaration) ||
                 updatedNode.IsKind(SyntaxKind.DelegateDeclaration) ||
+                updatedNode.IsKind(SyntaxKind.RecordStructDeclaration) ||
                 updatedNode.IsKind(SyntaxKind.RecordDeclaration))
             {
                 var updatedLeadingTrivia = UpdateParamTagsInLeadingTrivia(document, updatedNode, declarationSymbol, signaturePermutation);
@@ -293,8 +293,7 @@ public override async Task<SyntaxNode> ChangeSignatureAsync(
                 return method.WithParameterList(method.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
             }
 
-            // TODO: Record structs
-            if (updatedNode.IsKind(SyntaxKind.RecordDeclaration, out RecordDeclarationSyntax? record) && record.ParameterList is not null)
+            if (updatedNode is RecordDeclarationSyntax { ParameterList: not null } record)
             {
                 var updatedParameters = UpdateDeclaration(record.ParameterList.Parameters, signaturePermutation, CreateNewParameterSyntax);
                 return record.WithParameterList(record.ParameterList.WithParameters(updatedParameters).WithAdditionalAnnotations(changeSignatureFormattingAnnotation));
@@ -892,31 +891,15 @@ protected override SyntaxToken CommaTokenWithElasticSpace()
             => Token(SyntaxKind.CommaToken).WithTrailingTrivia(ElasticSpace);
 
         protected override bool TryGetRecordPrimaryConstructor(INamedTypeSymbol typeSymbol, [NotNullWhen(true)] out IMethodSymbol? primaryConstructor)
-        {
-            Debug.Assert(typeSymbol.IsRecord);
-            primaryConstructor = typeSymbol.InstanceConstructors.FirstOrDefault(
-                c => c.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax() is RecordDeclarationSyntax);
-            return primaryConstructor is not null;
-        }
+            => typeSymbol.TryGetRecordPrimaryConstructor(out primaryConstructor);
 
         protected override ImmutableArray<IParameterSymbol> GetParameters(ISymbol declarationSymbol)
         {
             var declaredParameters = declarationSymbol.GetParameters();
-            if (declarationSymbol is INamedTypeSymbol { IsRecord: true } recordSymbol)
-            {
-                Debug.Assert(declaredParameters.IsDefaultOrEmpty, "If GetParameters extension handles record, we can remove the handling here.");
-                // A bit hacky to determine the parameters of primary constructor associated with a given record.
-                // Simplifying is tracked by: https://github.com/dotnet/roslyn/issues/53092.
-                // Note: When the issue is handled, we can remove the logic here and handle things in GetParameters extension. BUT
-                // if GetParameters extension method gets updated to handle records, we need to test EVERY usage
-                // of the extension method and make sure the change is applicable to all these usages.
-                var primaryConstructor = recordSymbol.InstanceConstructors.FirstOrDefault(
-                    c => c.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax() is RecordDeclarationSyntax);
-
-                if (primaryConstructor is not null)
-                {
-                    declaredParameters = primaryConstructor.Parameters;
-                }
+            if (declarationSymbol is INamedTypeSymbol { IsRecord: true } recordSymbol &&
+                recordSymbol.TryGetRecordPrimaryConstructor(out var primaryConstructor))
+            {
+                declaredParameters = primaryConstructor.Parameters;
             }
 
             return declaredParameters;

src/Features/CSharp/Portable/Completion/CompletionProviders/XmlDocCommentCompletionProvider.cs

@@ -369,21 +369,10 @@ private string GetAttributeValue(XmlAttributeSyntax attribute)
         protected override ImmutableArray<IParameterSymbol> GetParameters(ISymbol declarationSymbol)
         {
             var declaredParameters = declarationSymbol.GetParameters();
-            if (declarationSymbol is INamedTypeSymbol { IsRecord: true } recordSymbol)
+            if (declarationSymbol is INamedTypeSymbol { IsRecord: true } recordSymbol &&
+                recordSymbol.TryGetRecordPrimaryConstructor(out var primaryConstructor))
             {
-                Debug.Assert(declaredParameters.IsDefaultOrEmpty, "If GetParameters extension handles record, we can remove the handling here.");
-                // A bit hacky to determine the parameters of primary constructor associated with a given record.
-                // Simplifying is tracked by: https://github.com/dotnet/roslyn/issues/53092.
-                // Note: When the issue is handled, we can remove the logic here and handle things in GetParameters extension. BUT
-                // if GetParameters extension method gets updated to handle records, we need to test EVERY usage
-                // of the extension method and make sure the change is applicable to all these usages.
-                var primaryConstructor = recordSymbol.InstanceConstructors.FirstOrDefault(
-                    c => c.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax() is RecordDeclarationSyntax);
-
-                if (primaryConstructor is not null)
-                {
-                    declaredParameters = primaryConstructor.Parameters;
-                }
+                declaredParameters = primaryConstructor.Parameters;
             }
 
             return declaredParameters;

src/Features/Core/Portable/ChangeSignature/AbstractChangeSignatureService.cs

@@ -132,12 +132,9 @@ internal async Task<ChangeSignatureAnalyzedContext> GetChangeSignatureContextAsy
                 {
                     symbol = typeSymbol.DelegateInvokeMethod;
                 }
-                else if (typeSymbol.IsRecord)
+                else if (typeSymbol.IsRecord && TryGetRecordPrimaryConstructor(typeSymbol, out var primaryConstructor))
                 {
-                    if (TryGetRecordPrimaryConstructor(typeSymbol, out var primaryConstructor))
-                    {
-                        symbol = primaryConstructor;
-                    }
+                    symbol = primaryConstructor;
                 }
             }
 

src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ITypeSymbolExtensions.cs

@@ -4,6 +4,8 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Diagnostics;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
@@ -177,5 +179,21 @@ public static bool IsIntrinsicType(this ITypeSymbol typeSymbol)
                     return false;
             }
         }
+
+        public static bool TryGetRecordPrimaryConstructor(this INamedTypeSymbol typeSymbol, [NotNullWhen(true)] out IMethodSymbol? primaryConstructor)
+        {
+            Debug.Assert(typeSymbol.IsRecord);
+            Debug.Assert(typeSymbol.GetParameters().IsDefaultOrEmpty, "If GetParameters extension handles record, we can remove the handling here.");
+
+            // A bit hacky to determine the parameters of primary constructor associated with a given record.
+            // Simplifying is tracked by: https://github.com/dotnet/roslyn/issues/53092.
+            // Note: When the issue is handled, we can remove the logic here and handle things in GetParameters extension. BUT
+            // if GetParameters extension method gets updated to handle records, we need to test EVERY usage
+            // of the extension method and make sure the change is applicable to all these usages.
+
+            primaryConstructor = typeSymbol.InstanceConstructors.FirstOrDefault(
+                c => c.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax() is RecordDeclarationSyntax);
+            return primaryConstructor is not null;
+        }
     }
 }