-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test: AddParameters_NoLastWhitespaceTrivia #53089
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes a NRE on Release. I'll get that fixed in #53052 StackTrace for reference:
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expecting this test to fail in debug due to an assertion failure deep in the compiler layer. The root cause here is that the given ConstructorDeclarationSyntax doesn't have a whitespace leading trivia. Causing the value of
lastWhiteSpaceTrivia
to remain thedefault
literal:roslyn/src/Features/Core/Portable/ChangeSignature/AbstractChangeSignatureService.cs
Line 937 in 89d820c
When it's passed to
SyntaxGenerator.DocumentationCommentTrivia
:roslyn/src/Features/Core/Portable/ChangeSignature/AbstractChangeSignatureService.cs
Lines 999 to 1003 in 89d820c
The following assertion fails:
roslyn/src/Compilers/Core/Portable/Syntax/SyntaxTrivia.cs
Line 63 in bc98ed9
Will see what also happens in Release.