Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update features/compiler with latest main #53090

Closed
wants to merge 293 commits into from
Closed

Update features/compiler with latest main #53090

wants to merge 293 commits into from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 2, 2021 •
edited
Loading

Needed to add IDE support for record struct documentation comments on top of #52737.

@akhera99
Fixed an incorrect line where allOccurences should've been true
5baa15c
@akhera99
Removed unnecessary code, working on connecting expression back to pa…
72a8578 
…rameters
@akhera99
MOdifies method calls in C#, currently adding VB support
767fd77
@akhera99
Adding VB items and associated tests
26f52a5
@akhera99
Moved find call sites to the abstract introduce parameter file since …
3caf932 
…it was not language dependent
@akhera99
Abstracted out the main function that calls all of the refactorings
9446775
@akhera99
Added logic to make sure you're highlight an expression that has vari…
7b74c81 
…ables
@akhera99
Split into trampoline vs. not trampoline
1d7195f
@akhera99
Changes based on review comments
44ad100
@akhera99
Responded to more feedback, moved the methods that tied parameters to…
a71d17a 
… variables to the abstract class because they no longer rely on language inherent items
@akhera99
Fixing changes made to incorrect file
4bfe528
@akhera99
Checking now to see if the expression has any variables before return…
baadda5 
…ing true
@akhera99
Made changes to how rewrite is done, no longer only look at methoddec…
50908ef 
…larationsyntax, changed from trampoline to overload
@akhera99
Added overload code
32ca6a0
@akhera99
Saving backup before changing annotations
35d72e5
@akhera99
Need to figure out why the spacing of the generated code gets weirdly…
b77b093 
… untabbed
@akhera99
Removed annotations
0db1e80
@akhera99
Added both trampolines, working on updating all occurrences
4e48c81
@akhera99
Now handles nested invocations
64ef766
@akhera99
Changed logic surrounding creating the new expression
df2a4e2
@akhera99
Added final tests/optional param support
0c504c9
@akhera99
Need to figure out what to do if getCurrentNode returns null
ca7e9ff
@akhera99
Added some comments for items and did null checks
4b9c785
@akhera99
Fixed type mismatch
cd0ed40
@akhera99
formatting fixes
bbfd2ae
@akhera99
Removed unnecessary code
3b08f76
@akhera99
Changed file names
0347e5f
@akhera99
Responded to PR feedback
bfd18f4
@akhera99
Removed usages of the IntroduceParameterCodeAction
f229270
@akhera99
REmoved containskey cehck
22a633a
dibarbet and others added 16 commits April 29, 2021 13:40
@dibarbet
Run LSP integration on CI builds only until they're stable
498414c
@akoeplinger
Remove eng/docker/mono.sh script (dotnet#51833)
7bea821 
It doesn't seem to be used anymore after dotnet#51815
@dibarbet
Explicitly define no PR triggers as they are on 'by default'
1d7cdf2
@dibarbet
Merge pull request dotnet#53033 from dotnet/merges/release/dev16.10-t…
e8e6d30 
…o-main

Merge release/dev16.10 to main
@sharwell
Fix caret placement for argument completion snippets
da2f728
@sharwell
Merge pull request dotnet#53040 from sharwell/caret-placement
8d08e88 
Fix caret placement for argument completion snippets
@dibarbet
Merge pull request dotnet#53032 from dibarbet/lsp_on_rolling
e1fd65d 
Run LSP integration on rolling builds only until they're stable
@AlekseyTs
Avoid false assert in AssertMemberExposure due to a race. (dotnet#53044)
3b1a1a4 
Fixes dotnet#52368.
@sharwell
Merge pull request dotnet#52976 from sharwell/oop-document-tracking
7f76171 
Add ServiceHub implementation of IDocumentTrackingService
@JoeRobich
Update version for 16.11
a7dec76
@sharwell
Merge pull request dotnet#53055 from dotnet/dev/jorobich/update-version
cdf4f8f 
Update version for 16.11
@dibarbet
Merge pull request dotnet#53046 from dotnet/merges/release/dev16.10-t…
46cbaab 
…o-main

Merge release/dev16.10 to main
@sharwell
Merge pull request dotnet#52947 from sharwell/handle-exception
0df296c 
Catch exceptions within LazyToolTip
@dibarbet
Merge remote-tracking branch 'upstream/release/dev16.11' into merges/…
3df52a7 
…release/dev16.11-to-main
Merge pull request dotnet#53062 from dotnet/merges/release/dev16.11-t…
525da64 
…o-main

Merge release/dev16.11 to main
@CyrusNajmabadi
Merge pull request dotnet#52737 from Youssef1313/doc-comment-records
bc98ed9 
Handle records in documentation comments in IDE side
@Youssef1313 Youssef1313 requested review from a team as code owners May 2, 2021 12:08
@Youssef1313 Youssef1313 closed this May 2, 2021
@Youssef1313 Youssef1313 deleted the main-snapshot branch May 2, 2021 13:25
@Youssef1313 Youssef1313 restored the main-snapshot branch May 2, 2021 13:38
@Youssef1313 Youssef1313 reopened this May 2, 2021
@jcouv
Copy link
Member

jcouv commented May 3, 2021

We shouldn't do this at the moment. We're only refreshing features/compiler from the 16.10 branch for now.

@jcouv jcouv closed this May 3, 2021
@Youssef1313 Youssef1313 deleted the main-snapshot branch May 3, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.