Enable CA2009: Do not call ToImmutableCollection on an ImmutableCollection value #53141
Conversation
| @@ -41,7 +41,7 @@ internal class OnAutoInsertHandler : AbstractStatelessRequestHandler<LSP.Documen | |||
| [ImportMany(LanguageNames.VisualBasic)] IEnumerable<IBraceCompletionService> visualBasicBraceCompletionServices) | |||
| { | |||
| _csharpBraceCompletionServices = csharpBraceCompletionServices.ToImmutableArray(); | |||
| _visualBasicBraceCompletionServices = _visualBasicBraceCompletionServices.ToImmutableArray(); | |||
| _visualBasicBraceCompletionServices = visualBasicBraceCompletionServices.ToImmutableArray(); | |||
There was a problem hiding this comment.
This looks like a bug!
@CyrusNajmabadi Any idea what this may have caused and how to test?
There was a problem hiding this comment.
I wonder if there was a test that could have shown an issue here.
There was a problem hiding this comment.
@CyrusNajmabadi I added a test. Haven't yet verified that it's failing before the change or passing after. Will test
There was a problem hiding this comment.
The test I added is unrelated to this line. It's not a brace completion service. Will see if I can figure out a test.
There was a problem hiding this comment.
I can't figure out a test. Most (if not all) of those VB services are unrelated to typing a new line, while OnAutoInsertHandler calls the services only if the character typed is a new line.
Head branch was pushed to by a user without write access
|
@CyrusNajmabadi @ryzngard There are unrelated test failures here. Can someone restart them? Thanks! |
|
Youssef, just wanted to confirm: the re-run button doesn't appear for you here in the Checks tab?
|
|
@RikkiGibson Yeah it doesn't (screenshot from another PR that has failing checks):
|
|
@CyrusNajmabadi @Youssef1313 is this good to merge? |
|
@RikkiGibson Yeah it should be. |
ghost
added this to the
|
Thanks @Youssef1313! |
No description provided.