Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Building, Debugging, and Testing on Windows.md #53543

Merged
merged 2 commits into from
May 22, 2021

Conversation

Youssef1313
Copy link
Member

binaries. This means trying out a change to the language, IDE or debugger is as
simple as hitting F5.
binaries. This means trying out a change to the IDE or debugger is as
simple as hitting F5. Note that changes to the compiler aren't recommended to be tested using Roslyn Deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than saying that something is not recommended, I think it is better to describe what should be expected. For example to say that out of process build by default doesn't use privately built version of the compiler. Why I think it is better, because there is still at least one way to get msbuild using the privately built version of the compiler by modifying project file and pointing it to the compiler, then end-to end testing would work.

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@AlekseyTs
Copy link
Contributor

@dotnet/roslyn-ide, @dotnet/roslyn-infrastructure It looks like the integration CI jobs are broken. I've seen them fail for several PRs lately, all four jobs at once.

@AlekseyTs
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AlekseyTs AlekseyTs merged commit 08b0040 into dotnet:main May 22, 2021
@ghost ghost added this to the Next milestone May 22, 2021
@Youssef1313 Youssef1313 deleted the patch-21 branch May 22, 2021 15:31
333fred added a commit that referenced this pull request May 24, 2021
…ures/interpolated-string

* upstream/main: (92 commits)
  Keep casts when necessary to prefer a constant pattern over a type pattern
  Remove SyntaxKind.DataKeyword (#53614)
  Display 'readonly' for record structs (#53634)
  Update Building, Debugging, and Testing on Windows.md (#53543)
  Update dependencies from https://github.com/dotnet/arcade build 20210521.3 (#53617)
  Introduce resx for BuildValidator and MS.CA.Rebuild to allow localization (#53447)
  Report obsoletion diagnostics for slice and indexer (#53463)
  Update BasicGenerateConstructorDialog.cs
  Add searchbox in generate overrides dialog
  Allow `with` on anonymous types (#53248)
  Report diagnostic on correct node (#53538)
  Fix NotNullIfNotNull delegate conversion (#53409)
  Verify quick info session in InvokeQuickInfo
  Remove unnecessary retry
  Ensure no navbar IO on the UI thread
  Enable nullable reference types
  Fix timeout behavior in GetQuickInfo
  Add a semantic model based GetQuickInfoAsync entry point into QuickInfoServiceWithProviders
  Move semantic model based quick info API up to CommonQuickInfoProvider type
  Fix dnceng build by forcing the use of xcopy msbuild
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants