-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Building, Debugging, and Testing on Windows.md #53543
Conversation
binaries. This means trying out a change to the language, IDE or debugger is as | ||
simple as hitting F5. | ||
binaries. This means trying out a change to the IDE or debugger is as | ||
simple as hitting F5. Note that changes to the compiler aren't recommended to be tested using Roslyn Deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than saying that something is not recommended, I think it is better to describe what should be expected. For example to say that out of process build by default doesn't use privately built version of the compiler. Why I think it is better, because there is still at least one way to get msbuild using the privately built version of the compiler by modifying project file and pointing it to the compiler, then end-to end testing would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 2)
@dotnet/roslyn-ide, @dotnet/roslyn-infrastructure It looks like the integration CI jobs are broken. I've seen them fail for several PRs lately, all four jobs at once. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…ures/interpolated-string * upstream/main: (92 commits) Keep casts when necessary to prefer a constant pattern over a type pattern Remove SyntaxKind.DataKeyword (#53614) Display 'readonly' for record structs (#53634) Update Building, Debugging, and Testing on Windows.md (#53543) Update dependencies from https://github.com/dotnet/arcade build 20210521.3 (#53617) Introduce resx for BuildValidator and MS.CA.Rebuild to allow localization (#53447) Report obsoletion diagnostics for slice and indexer (#53463) Update BasicGenerateConstructorDialog.cs Add searchbox in generate overrides dialog Allow `with` on anonymous types (#53248) Report diagnostic on correct node (#53538) Fix NotNullIfNotNull delegate conversion (#53409) Verify quick info session in InvokeQuickInfo Remove unnecessary retry Ensure no navbar IO on the UI thread Enable nullable reference types Fix timeout behavior in GetQuickInfo Add a semantic model based GetQuickInfoAsync entry point into QuickInfoServiceWithProviders Move semantic model based quick info API up to CommonQuickInfoProvider type Fix dnceng build by forcing the use of xcopy msbuild ...
See #53535 (comment).
cc @AlekseyTs