Merge 'main' into 'features/struct-ctors' #53578

…tructors IDE shoudl not attempt to replicate the compiler to generate diagnostics inside lambdas for constructors.

Switch pattern matching to use TemporaryArray

Combine duplicate private methods by one method having base class as parameter

…onFlag Remove EnC completion flag

Merge features/source-build to main

Add records to C# declaration comparer

Fix spans for cached items at the manager level, not the service level

…checks-to-nullable-parameters Don't suggest to add null checks to nullable reference types

Add additional info to contract call

…rt soft selection

…o-main Merge release/dev16.11 to main

Use NRT

…lenceKeys Use separate equivalence keys for pattern matching fixes.

Improve far multi-targetting grouping for one more case.

Use the `not` pattern

Use patterns

…ot support soft selection" This reverts commit 1c946b9.

…soft selection in VSCode. Also always specify commit characters in VSCode as they do not use the defaults to override.

Use segmented dictionaries in SyntaxNodeExtensions.CurrentNodes

Backporting fixes to dev16.11

Pool background threads used for trampolines

…o-main Merge release/dev16.11 to main

Disable trigger in argument completion in VSCode as it does not suppo…

Fix NavBars for TS (aka: TypeScript and F# are different languages).

…52833 Introduce local constant results in compiler error when new local name equals identifier name in method block

Update LSP tooltips to better support markdown

Fix collapse to definitions for top-level statements

Update version for 16.10 preview 4

…o-release/dev16.11 Merge release/dev16.10 to release/dev16.11

[main] Update dependencies from dotnet/arcade - Merge branch 'main' into darc-main-bc4cb993-581c-4983-84f1-5f8586da3b83 - Update DotNet.Feeds to 6.0.0-beta.21260.1

…release/dev16.10-to-release/dev16.11

…o-release/dev16.11 Merge release/dev16.10 to release/dev16.11

FIXES dotnet#52589

…piler

Add endpoint for public semantic tokens LSP API

Merge `features/compiler` into `release/dev16.11`

…513.1 (dotnet#53389) [main] Update dependencies from dotnet/arcade

Update vssdk version

Tracking issues - dotnet#46414 - dotnet#53392

We don't let a user rename symbols that are defined in source generated files, but in some scenarios we may cascade to them. This prevents us from updating those cascaded definitions either. The assumption in such a change is that the names in generated files are being generated from some of the original definitions that are being renamed, and so everything will refresh. Fixes dotnet#51537 # Conflicts: # src/EditorFeatures/Test2/Rename/RenameEngineResult.vb

Move off of the legacy IVsPackageInstallerServices.IsPackageInstalled API.

When we changed the logic for finding declared symbols in ca2505a, we now would see the case label as declaring the symbol which we don't want. As a conservative choice, we'll do the expanded logic only for operators where it was originally intended. Fixes dotnet#53269

…inding Correctly find enum members in case labels

…de-into-generated-file Don't attempt to edit source generated files during rename

For testing OOP serialization in unit tests, we spin up an in-proc "remote" provider which does all the serialization and synchronization like we would for OOP, just without the actual separate process. One problem for unit tests was this had the some of the same limitations of our OOP sync. Specifically, we only supported synchronizing AnalyzerFileReferences, since that was implemented by loading the analyzer on the other side. For unit tests around source generator support, we have a TestGeneratorReference helper which is an AnalyzerReference that directly holds onto an instance of a generator. Since a TestGeneratorReference isn't an AnalyzerFileReference, this meant we couldn't test scenarios that had generators in our "remote" provider we used in unit tests. This change cheats a little bit in the OOP serialization layer, and in tests allows us to "serialize" a TestGeneratorReference to the remote workspace so the generator is running there too. In our unit tests we create an entirely separate MEF composition for the remote workspace to ensure isolation, but we'll cheat and share a single map of GUID to TestSourceGenerator between the two MEF compositions. "Serializing" a TestGeneratorReference is then adding something into that map, and the other side can read back out. This is a part of dotnet#50494.

Turns out there was a bug here if you were using OOP and the non- streaming API. Fixes dotnet#50494

Turns out all our tests that ran in the "out of proc" test hosts never did that. They kept working because everything fell back to the in-proc methods.

This reverts commit 0d48d62.

Fix OOP tests around Find References and Rename

…o-main Merge release/dev16.11 to main

Item with prefix causes out of range exception

…wsable Have add-using respect EditorBrowsable attributes.

Add test for completion items with prefix in resolve

[main] Update dependencies from dotnet/arcade

Fix IDE0047: discard pattern parentheses

Fix typo: Carrage -> Carriage

Fixes dotnet#53415 The Assembly.RuntimeSupports* was never true in these tests. Use ```TargetFramework.StandardLatest``` for compilations so both code paths are actually tested.

…release/dev16.11-to-main

…matted (dotnet#53414)

Update to P2

…o-main Merge release/dev16.11 to main

Don't generate nullable type when applying value type with unconstrained nullable generic

Fix the VS branches for dev17 preview1 and main

Update PublishData.json

Revert an error in PublishData.json

… initializer (dotnet#53326)

…3241)" (dotnet#53466) This reverts commit 82ce937.

Refactor automation object and add missing options.

Closes dotnet#42550

Fix out of bound crash in lsp navto.

These should have been left as is as a part of 299d55d, as this otherwise created breaking API changes.

…o-main Merge release/dev16.11 to main

Only require telemetry validation in CI

…pi-break Revert changes to TypeScriptWaitContext wrappers

Port 'Fix out of bound crash in lsp navto' to dev 16.11

Fix locked comment

The PR dotnet#53138 moved us to using .NET 6 Preview 3 but did not update our documentation. Historically moving to new .NET SDK versions was manual process and we "knew" to update the docs when we updated the version. Now though it's flowing automatically via arcade and we missed it. Short term this will get the docs in line with the requirements. Longer term though working on a way to make sure automation doesn't silently break our docs here.

…o-main Merge release/dev16.11 to main

Fix global state corruption in EditorConfig UI

…torFix Maintain the same parse option when add symbol to destination

…o-release/dev16.11 Merge release/dev16.10 to release/dev16.11

Only generate build number on first run

…space_checkchangesupported Check the workspace supports ApplyChangesKind.ChangeDocumentInfo

…o-release/dev16.11 Merge release/dev16.10 to release/dev16.11

…o-main Merge release/dev16.11 to main

Ensure no navbar IO on the UI thread

Fix timeout

…o-main Merge release/dev16.11 to main

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge 'main' into 'features/struct-ctors' #53578

Merge 'main' into 'features/struct-ctors' #53578

Commits on May 7, 2021

Commits on May 8, 2021

Commits on May 9, 2021

Commits on May 10, 2021

Commits on May 11, 2021

Commits on May 12, 2021

Commits on May 13, 2021

Commits on May 14, 2021

Commits on May 15, 2021

Commits on May 16, 2021

Commits on May 17, 2021

Commits on May 18, 2021

Commits on May 19, 2021

Commits on May 20, 2021

Commits on May 21, 2021