Make Inheritance Margin Zoom Level is divided by 100 #54828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
commented
Jul 14, 2021
|
|
||
| // ZoomLevel is 100 based. (e.g. 150%, 100%) | ||
| // ScaleFactor is 1 based. (e.g. 1.5, 1) | ||
| var scaleFactor = zoomLevel / 100; |
There was a problem hiding this comment.
I move the zoom level -> scaleFactor conversion here so that this could be covered by the unit test change below
Cosifne
commented
Jul 14, 2021
| Dim actualViewModel = InheritanceMarginViewModel.Create( | ||
| classificationTypeMap, classificationFormatMap.GetClassificationFormatMap("tooltip"), acutalTag, 1) | ||
| classificationTypeMap, classificationFormatMap.GetClassificationFormatMap("tooltip"), acutalTag, 100) |
There was a problem hiding this comment.
All the unit tests below are expecting a ViewModel that has 1 scaleFactor, change the value here to be 100 to match TextView.ZoomLevel, it will make sure the conversion is not missed
davidwengier
approved these changes
Jul 14, 2021
Cosifne
force-pushed
the
dev/shech/InheritanceMarginZoomLevelFix
branch
from
487a42b
to
f790337
Compare
|
Seems good on my machine now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54521