Address Interpolated Strings test plan #55701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a couple of test failures In reply to: 901449708 |
|
@jcouv should be fixed, please take a look. |
jcouv
reviewed
Aug 19, 2021
| @@ -825,7 +825,16 @@ private ImmutableArray<BoundExpression> BindInterpolatedStringParts(BoundUnconve | |||
| var interpolatedStringConversion = memberAnalysisResult.ConversionForArg(interpolatedStringArgNum); | |||
| Debug.Assert(interpolatedStringConversion.IsInterpolatedStringHandler); | |||
| var interpolatedStringParameter = GetCorrespondingParameter(ref memberAnalysisResult, parameters, interpolatedStringArgNum); | |||
| Debug.Assert(interpolatedStringParameter.Type is NamedTypeSymbol { IsInterpolatedStringHandlerType: true }); | |||
| Debug.Assert(interpolatedStringParameter is { Type: NamedTypeSymbol { IsInterpolatedStringHandlerType: true } } | |||
| #pragma warning disable format | |||
There was a problem hiding this comment.
nit: Do we need a tracking issue for formatting problem?
There was a problem hiding this comment.
@sharwell, do you know if there's a tracking issue for the formatter pulling this or all the way to the right, rather than leaving it aligned as it?
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
reviewed
Aug 19, 2021
jcouv
approved these changes
Aug 20, 2021
chsienki
approved these changes
Aug 20, 2021
Followed up on the spec offline. There is already a note about erroring in the case of bad info. |
… using InterpolatedStringHandlerArgumentAttribute on a lambda.
ghost
added this to the 
333fred
added
the
Feature - Interpolated String Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses remaining compiler items on the interpolated strings test plan: #51499. I would highly recommend commit-by-commit review for these. The first few commits add tests and fix small bugs found with the tests. The last commit bundles the tests that were simply added with no other changes necessary.