Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable apphost build of 'csi', 'vbi' for source-build #57306

Closed
wants to merge 1 commit into from
Closed

Disable apphost build of 'csi', 'vbi' for source-build #57306

wants to merge 1 commit into from

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 21, 2021

@dagood dagood requested a review from a team as a code owner October 21, 2021 17:48
@JoeRobich
Copy link
Member

Integration failures are expected and will be working again once #57281 merges.

This was referenced Oct 22, 2021
Closed
Closed
lbussell pushed a commit to lbussell/roslyn that referenced this pull request Jan 7, 2022
@dagood @lbussell
Disable apphost build of 'csi', 'vbi' for source-build
111ae8c 
Creating an apphost for a netcoreapp3.1 project uses the apphost pack as a
prebuilt. Stopping these projects from creating the apphost removes the prebuilt
for source-build.

See: dotnet#57233

PR: dotnet#57306
lbussell pushed a commit to lbussell/roslyn that referenced this pull request Jan 25, 2022
@dagood @lbussell
Disable apphost build of 'csi', 'vbi' for source-build
077fcca 
Creating an apphost for a netcoreapp3.1 project uses the apphost pack as a
prebuilt. Stopping these projects from creating the apphost removes the prebuilt
for source-build.

See: dotnet#57233

PR: dotnet#57306
@kasperk81
Copy link

is this ready to merge (after resolving conflicts)? this often cause patch conflict in installer repo and holds back the update

@tmat
Copy link
Member

tmat commented Jan 26, 2022

Yes

@dagood
Copy link
Member Author

dagood commented Jan 26, 2022

/cc @dotnet/source-build-internal

@MichaelSimons
Copy link
Member

This should be closed in preference of #58727.

@dagood dagood closed this Jan 26, 2022
@dagood dagood deleted the csi-no-apphost branch January 26, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dagood @JoeRobich @kasperk81 @tmat @MichaelSimons